git cl set-commit: actually apply passed --rietveld / --gerrit options

BUG=600945

Recipe-Tryjob-Bypass-Reason: expectation changes expected and wanted
Review-Url: https://codereview.chromium.org/2234873002
1 file changed
tree: 0b58f55bff1b483e8e349c95693137365d4d916b
  1. bootstrap/
  2. fetch_configs/
  3. git-templates/
  4. infra/
  5. man/
  6. recipe_modules/
  7. support/
  8. testing_support/
  9. tests/
  10. third_party/
  11. win_toolchain/
  12. zsh-goodies/
  13. .gitignore
  14. .style.yapf
  15. annotated_gclient.py
  16. apply_issue
  17. apply_issue.bat
  18. apply_issue.py
  19. auth.py
  20. breakpad.py
  21. buildbucket.py
  22. checkout.py
  23. chrome-update-create-task.bat
  24. chrome-update.bat
  25. chrome-update.py
  26. cit
  27. cit.bat
  28. cit.py
  29. clang-format
  30. clang-format.bat
  31. clang_format.py
  32. codereview.settings
  33. commit_queue
  34. commit_queue.bat
  35. commit_queue.py
  36. cpplint.bat
  37. cpplint.py
  38. cpplint_chromium.py
  39. create-chromium-git-src
  40. create-ntfs-junction.c
  41. create-ntfs-junction.exe
  42. dart_format.py
  43. depot-tools-auth
  44. depot-tools-auth.bat
  45. depot-tools-auth.py
  46. download_from_google_storage
  47. download_from_google_storage.bat
  48. download_from_google_storage.py
  49. drover
  50. drover.bat
  51. drover.py
  52. fetch
  53. fetch.bat
  54. fetch.py
  55. fix_encoding.py
  56. gcl
  57. gcl.bat
  58. gcl.py
  59. gclient
  60. gclient-new-workdir.py
  61. gclient.bat
  62. gclient.py
  63. gclient_completion.sh
  64. gclient_scm.py
  65. gclient_utils.py
  66. gerrit_util.py
  67. git-auto-svn
  68. git-cache
  69. git-cherry-pick-upload
  70. git-cl
  71. git-crrev-parse
  72. git-crsync
  73. git-drover
  74. git-find-releases
  75. git-footers
  76. git-freeze
  77. git-gs
  78. git-hyper-blame
  79. git-map
  80. git-map-branches
  81. git-mark-merge-base
  82. git-nav-downstream
  83. git-nav-upstream
  84. git-new-branch
  85. git-number
  86. git-rebase-update
  87. git-rename-branch
  88. git-reparent-branch
  89. git-retry
  90. git-runhooks
  91. git-squash-branch
  92. git-thaw
  93. git-upstream-diff
  94. git_auto_svn.py
  95. git_cache.py
  96. git_cherry_pick_upload.py
  97. git_cl.py
  98. git_common.py
  99. git_dates.py
  100. git_drover.py
  101. git_find_releases.py
  102. git_footers.py
  103. git_freezer.py
  104. git_hyper_blame.py
  105. git_map.py
  106. git_map_branches.py
  107. git_mark_merge_base.py
  108. git_nav_downstream.py
  109. git_new_branch.py
  110. git_number.py
  111. git_rebase_update.py
  112. git_rename_branch.py
  113. git_reparent_branch.py
  114. git_retry.py
  115. git_squash_branch.py
  116. git_upstream_diff.py
  117. gn
  118. gn.bat
  119. gn.py
  120. gsutil.py
  121. LICENSE
  122. my_activity.py
  123. my_reviews.py
  124. ninja
  125. ninja-linux32
  126. ninja-linux64
  127. ninja-mac
  128. ninja.exe
  129. OWNERS
  130. owners.py
  131. owners_finder.py
  132. patch.py
  133. PRESUBMIT.py
  134. presubmit_canned_checks.py
  135. presubmit_support.py
  136. profile.xml
  137. pylint
  138. pylint.py
  139. pylintrc
  140. python_runner.sh
  141. README.codereview
  142. README.gclient
  143. README.git-cl
  144. README.md
  145. README.testing
  146. recipes.py
  147. repo
  148. rietveld.py
  149. roll-dep
  150. roll-dep-svn
  151. roll-dep-svn.bat
  152. roll-dep.bat
  153. roll_dep.py
  154. roll_dep_svn.py
  155. scm.py
  156. setup_color.py
  157. subcommand.py
  158. subprocess2.py
  159. trychange.py
  160. update_depot_tools
  161. update_depot_tools.bat
  162. upload_to_google_storage.py
  163. WATCHLISTS
  164. watchlists.py
  165. weekly
  166. wtf
README.md

This package contains tools for working with Chromium development:

chrome-update-create-task.bat Creates a scheduled task to do an automatic local chromium build every day.

cpplint.py A copy of our linting tool which enforces Google style. Fetched from http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py

gcl A tool for uploading and managing code reviews on the Chromium project, using the Rietveld code review tool. More info at: http://code.google.com/p/rietveld/

gclient A script for managing a workspace with modular dependencies that are each checked out independently from different repositories. More info at: http://code.google.com/p/gclient/

It updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0

To update package manually, run .\update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

Note: on Windows if svn, git and python are not accessible, they will be downloaded too.

Contributing

The “gclient” wrapper knows how to keep this repository updated to the latest versions of these tools as found at:

https://chromium.googlesource.com/chromium/tools/depot_tools.git

To contribute change for review:

git new-branch <somename>
git add <yourchanges>
git commit
# find reviewers
git cl owners
git log <yourfiles>
# upload
git cl upload -r reviewer1@chromium.org,reviewer2 --send-mail
# open https://codereview.chromium.org/ and send mail

# if change is approved, flag it to be commited
git cl set_commit
# if change needs more work
git rebase-update
...
git cl upload