commit | 7d880cffd9e682e6dbc180d36b57166408e25728 | [log] [tgz] |
---|---|---|
author | Moe Ahmadi <mahmadi@chromium.org> | Wed Jan 16 21:24:01 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jan 16 21:24:01 2019 |
tree | 7c15f8a58bce7495f907c7da1dbbb7b309b50751 | |
parent | 78267f5c868ebd407eda67c47adc1f8c5505292a [diff] |
[Translate] Keep infobar when toggling setting in TranslateInfoBarDelegate This CL changes the TranslateInfoBarDelegate so that it does not remove the infobar when ToggleTranslatableLanguageByPrefs and ToggleSiteBlacklist are called for the following reasons: 1. These methods are doing more than their names suggest they do. 2. Their logic can be simplified if the call to remove the infobar is made in TranslateCompactInfoBar because these methods are only called in TranslateCompactInfoBar and the infobar always gets removed as a result of those calls. Bug: 910994 Change-Id: Iad4919a69b41980d283cd33804107339f2ad6197 Reviewed-on: https://chromium-review.googlesource.com/c/1412733 Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#623373}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .