commit | 7ebbe90a16083547e3af395ba694c88196982b9a | [log] [tgz] |
---|---|---|
author | David Bokan <bokan@chromium.org> | Tue Feb 13 17:41:54 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Feb 13 17:41:54 2018 |
tree | f87fd1f49694667ab11927ffbb902739cfeb2ac9 | |
parent | 30f8822a37972aabd4b76d4559d1062d6799c9cb [diff] |
[Reland] Add a scrolling test for find-in-page Turning on root-layer-scrolling caused find in page to break in Android but wasn't turned up by tests. This CL adds a test to fill the gap. The regression was incidentally fixed in r535827. Also update TextFinder to use AbsoluteToRootFrame rather than ContentsToRootFrame. The two are equivalent but I'd like to eventually remove the Contents nomenclature since it can be easily confused for being relative to the document origin. This CL has no functional changes. [Reland Note] Fixes unreachable code build failure. TBR=treib@chromium.org,skobes@chromium.org,paulmeyer@chromium.org Bug: 810067 Change-Id: Iee35b2e5ef27c4a8985080b6962108f64b947a17 Reviewed-on: https://chromium-review.googlesource.com/915786 Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#536403}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .