commit | 7f063158562d2516620386721deb1339a3160e19 | [log] [tgz] |
---|---|---|
author | Bruce Dawson <brucedawson@chromium.org> | Wed Jan 31 21:33:08 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jan 31 21:33:08 2018 |
tree | 820c9cb900763ccd08f5e2415767d52520f567b5 | |
parent | 9f1fa9c053e29a586ccbd52c1f58d16e6de3318b [diff] |
Revert "Disable incremental linking for some tools" This reverts commit 1942fd8a7fe9fc609f51ef1fbff210ba5f356415. Reason for revert: This was a hack that attempted to fix random link failures. This hack ultimately didn't work because the crashes we were seeing were due to a kernel bug, not a linker bug. Original change's description: > Disable incremental linking for some tools > > We occasionally get build crashes because binaries (usually protoc.exe, > but others as well) are generated incorrectly. The symptom is that the > incremental linking thunks contain all zeroes instead of a branch > instruction, leading to crashes, usually access violations. This is > presumed to be a bug in the MSVC++ incremental linker. > > This turns off incremental linking for four of the binaries that hit > this issue most frequently, and some of their neighbors. These binaries > are all small enough that incremental linking is not important so there > is no real downside to making this change. > > Testing over the weekend shows that this error, or something very like > it, can happen even with incremental linking disabled. I hope that this > will reduce the frequency of the failures and there is no downside so > I'm going to proceed and see if it helps. > > Bug: 644525 > Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I0a9b33b0ad8335868e8e6f227f9a21e5ddeff6e4 > Reviewed-on: https://chromium-review.googlesource.com/777764 > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517990} TBR=jam@chromium.org,brucedawson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 644525 Change-Id: Ib822f0850cdffe7cdf0112aac5c45a2200b63adf Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/894448 Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#533419}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .