Google Git
Sign in
chromium / chromium / tools / depot_tools / 7fa0f19f7349037f37610a703e0dfddd3cda5e50
commit7fa0f19f7349037f37610a703e0dfddd3cda5e50[log] [tgz]
authorEdward Lemur <ehmaldonado@chromium.org>Tue Jul 17 21:33:37 2018
committerCommit Bot <commit-bot@chromium.org>Tue Jul 17 21:33:37 2018
tree2a8f5f5b42aebd22e0a95c138b8ca6b05df7e04a
parente6ddf1942ca0bf77e29c8e461e664db9efe397f7 [diff]
metrics: Fix countdown to metrics collection.

We were printing the notice when the decorator was called, so that if
several functions are decorated, the countdown will increase more than once
during each execution.

This change fixes that.

Bug: 832386
Change-Id: I5d6dd2d793137e1e2c83b6cc765b6245080b9d91
Reviewed-on: https://chromium-review.googlesource.com/1141073
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
2 files changed
tree: 2a8f5f5b42aebd22e0a95c138b8ca6b05df7e04a
  1. bootstrap/
  2. fetch_configs/
  3. git-templates/
  4. infra/
  5. man/
  6. recipes/
  7. support/
  8. testing_support/
  9. tests/
  10. third_party/
  11. win_toolchain/
  12. zsh-goodies/
  13. cbuildbot ⇨ support/chromite_wrapper
  14. chrome_set_ver ⇨ support/chromite_wrapper
  15. cros ⇨ support/chromite_wrapper
  16. cros_sdk ⇨ support/chromite_wrapper
  17. .gitattributes
  18. .gitignore
  19. .style.yapf
  20. annotated_gclient.py
  21. appengine_mapper.py
  22. auth.py
  23. autoninja
  24. autoninja.bat
  25. autoninja.py
  26. breakpad.py
  27. buildbucket.py
  28. checkout.py
  29. cipd
  30. cipd.bat
  31. cipd.ps1
  32. cipd_bin_setup.bat
  33. cipd_bin_setup.sh
  34. cipd_client_version
  35. cipd_manifest.txt
  36. cit
  37. cit.bat
  38. cit.py
  39. clang-format
  40. clang-format.bat
  41. clang_format.py
  42. clang_format_merge_driver
  43. clang_format_merge_driver.bat
  44. clang_format_merge_driver.py
  45. codereview.settings
  46. compile_single_file
  47. compile_single_file.bat
  48. compile_single_file.py
  49. cpplint.bat
  50. cpplint.py
  51. cpplint_chromium.py
  52. dart_format.py
  53. depot-tools-auth
  54. depot-tools-auth.bat
  55. depot-tools-auth.py
  56. detect_host_arch.py
  57. download_from_google_storage
  58. download_from_google_storage.bat
  59. download_from_google_storage.py
  60. ensure_bootstrap
  61. fetch
  62. fetch.bat
  63. fetch.py
  64. fix_encoding.py
  65. gclient
  66. gclient-new-workdir.py
  67. gclient.bat
  68. gclient.py
  69. gclient_completion.sh
  70. gclient_eval.py
  71. gclient_scm.py
  72. gclient_utils.py
  73. gerrit_client.py
  74. gerrit_util.py
  75. git-cache
  76. git-cl
  77. git-crrev-parse
  78. git-crsync
  79. git-drover
  80. git-find-releases
  81. git-footers
  82. git-freeze
  83. git-gs
  84. git-hyper-blame
  85. git-map
  86. git-map-branches
  87. git-mark-merge-base
  88. git-nav-downstream
  89. git-nav-upstream
  90. git-new-branch
  91. git-number
  92. git-rebase-update
  93. git-rename-branch
  94. git-reparent-branch
  95. git-retry
  96. git-runhooks
  97. git-squash-branch
  98. git-thaw
  99. git-upstream-diff
  100. git_cache.py
  101. git_cl.py
  102. git_cl_completion.sh
  103. git_common.py
  104. git_dates.py
  105. git_drover.py
  106. git_find_releases.py
  107. git_footers.py
  108. git_freezer.py
  109. git_hyper_blame.py
  110. git_map.py
  111. git_map_branches.py
  112. git_mark_merge_base.py
  113. git_nav_downstream.py
  114. git_new_branch.py
  115. git_number.py
  116. git_rebase_update.py
  117. git_rename_branch.py
  118. git_reparent_branch.py
  119. git_retry.py
  120. git_squash_branch.py
  121. git_upstream_diff.py
  122. gn
  123. gn.bat
  124. gn.py
  125. gsutil.py
  126. gsutil.vpython
  127. led
  128. led.bat
  129. LICENSE
  130. luci-auth
  131. luci-auth.bat
  132. mac_toolchain
  133. metrics.py
  134. metrics.README.md
  135. metrics_utils.py
  136. my_activity.py
  137. my_reviews.py
  138. ninja
  139. ninja-linux32
  140. ninja-linux64
  141. ninja-mac
  142. ninja.exe
  143. OWNERS
  144. owners.py
  145. owners_finder.py
  146. patch.py
  147. post_build_ninja_summary.py
  148. PRESUBMIT.py
  149. presubmit_canned_checks.py
  150. presubmit_support.py
  151. profile.xml
  152. prpc
  153. prpc.bat
  154. pylint
  155. pylint.py
  156. pylintrc
  157. python_runner.sh
  158. README.gclient.md
  159. README.git-cl.md
  160. README.md
  161. README.testing
  162. repo
  163. rietveld.py
  164. roll-dep
  165. roll-dep-svn
  166. roll-dep-svn.bat
  167. roll-dep.bat
  168. roll_dep.py
  169. roll_dep_svn.py
  170. scm.py
  171. setup_color.py
  172. split_cl.py
  173. subcommand.py
  174. subprocess2.py
  175. update_depot_tools
  176. update_depot_tools.bat
  177. update_depot_tools_toggle.py
  178. upload_metrics.py
  179. upload_to_google_storage.py
  180. vpython
  181. vpython.bat
  182. WATCHLISTS
  183. watchlists.py
  184. weekly
  185. wtf
  186. yapf
  187. yapf.bat
README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

To update cpplint.py, please submit the change upstream first at https://github.com/google/styleguide/tree/gh-pages/cpplint then copy it down.