commit | 7fa7ef3bfd087d66ddfb7cbd8ad7297ef8b09b51 | [log] [tgz] |
---|---|---|
author | Christian Biesinger <cbiesinger@chromium.org> | Thu Feb 07 19:33:09 2019 |
committer | Christian Biesinger <cbiesinger@chromium.org> | Thu Feb 07 19:33:09 2019 |
tree | e96b971870e063f0ffb3fe546e05d7e7e260cace | |
parent | 3866cfd5bc7ecffa5573323177a1304e3744b20f [diff] |
[css-flexbox] Don't apply min-height: auto to children with percentage heights In such a case, we compute an incorrect intrinsic logical height, because we resolve pre-flex percentages when we calculate the intrinsic height. In common cases this can be 100% of the flexbox height, which we later use as a min-height of the flex item, leading to it not shrinking when it should. This reverts https://crrev.com/c/1269235 for the case of a flex item which is a flexbox with percentage children. Bug: 927066 Change-Id: I955bf651f75495122bb454d5221303b188bbb03c Reviewed-on: https://chromium-review.googlesource.com/c/1452477 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#628806}(cherry picked from commit 4f73107eed2d8f61e189dcd52239159129961750) Reviewed-on: https://chromium-review.googlesource.com/c/1459323 Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#280} Cr-Branched-From: e51029943e0a38dd794b73caaf6373d5496ae783-refs/heads/master@{#625896}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .