commit | 800d47b989ca8294fc63f5a921c26418a98c8b72 | [log] [tgz] |
---|---|---|
author | Koji Ishii <kojii@chromium.org> | Wed Sep 12 08:39:49 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Sep 12 08:39:49 2018 |
tree | 67aeb2ed59542d054c291748ce4fc897e45d6bbf | |
parent | 7ec97292669288fff06627bb7c88745a8481401e [diff] |
[LayoutNG] Fix scrollWidth/scrollLeft when children are not inline r590138 (CL:1215365) fixed scrollWidth when box is narrower than the scrollbar width, but the apporach had two problems: 1. It does not fix if children are not inline, because LayoutNGMixin::AddOverflowFromChildren() computes overflow from fragments only when children are inline, but delegates to LayoutObject if otherwise. 2. scrollWidth was fixed, but scrollLeft is still incorrect in some cases. This causes LayoutObject to compute incorrect scrollWidth. Instead of adjusting overflow, this patch adjusts inline offset of fragments by clamping the scrollbar inline size to the content box. This method computes scrollWidth/scrollLeft same as legacy regardless of children. Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I401b245400b7a3fb2717bdcb5cdaa8edd34d928e Reviewed-on: https://chromium-review.googlesource.com/1217920 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#590622}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .