commit | 8033ba735a7599fce31ca14587ee241fcd3845ac | [log] [tgz] |
---|---|---|
author | Antonio Gomes <tonikitoo@igalia.com> | Tue Aug 28 22:04:34 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Tue Aug 28 22:04:34 2018 |
tree | 1f84485c3cd189be500e52e1ea4a9ce749e5da3f | |
parent | cc343aac3c8932ecf4e993f9a9a8fef0c7288d32 [diff] |
Rewrite HttpIceConfigRequestTest not to mock results This CL is a follow up of [1], where remoting::ChromiumUrlRequest migrated away from URLFetcher to SimpleURLLoader. During the migration, it was observed the ChromiumUrlRequest actual fetch/load machinery was not exercised at all by tests. This CL is a first step to fill this gap: rather than fully mock remoting::UrlRequest results, it now makes use of TestURLLoaderFactory and ChromiumUrlRequest. BUG=773295 Change-Id: Ie93fca014d4ae7186cfae9582568657476e5fd88 Reviewed-on: https://chromium-review.googlesource.com/1194622 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by: Joe Downing <joedow@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#586878}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .