commit | 804f1d9c19d600e5cd94fd554360421d415b5f4a | [log] [tgz] |
---|---|---|
author | Jonathan Nieder <jrn@google.com> | Tue May 31 13:39:05 2016 -0700 |
committer | Hugo Arès <hugo.ares@ericsson.com> | Wed Jun 01 08:27:48 2016 -0400 |
tree | 232143561933416ebcd74b88e08d2a52f78ada53 | |
parent | af239709596400fe0e10d621b68f539f3c1bf6a5 [diff] |
Drain executor of index change requests before closing index IndexCollection.stop() closes the index to flush pending index writes at shutdown. Unfortunately some pending index writes can be enqueued in the index executor without the index even being aware of them yet, causing lost writes on exit. Drain the work queue to avoid this. This has always been possible in a gerrit instance with >1 index threads (e.g., with '[index] threads = 2' in gerrit.config). 176cd58bb0bb (Always use a thread pool for interactive indexing, 2016-05-09) made Gerrit use a thread pool with multiple threads for indexing by default, making the problem easier to trigger. Noticed by using ctrl+c to exit gerrit daemon in a development environment. Making the close calls parallel as in a44d8396e72d (Lucene: close sub-indexes in parallel, 2013-06-21) can wait for a followup change. Change-Id: I7bda1305858fe4aa5ea12a4bc68d35f0cdedf225
Gerrit is a code review and project management tool for Git based projects.
Gerrit makes reviews easier by showing changes in a side-by-side display, and allowing inline comments to be added by any reviewer.
Gerrit simplifies Git based project maintainership by permitting any authorized user to submit changes to the master Git repository, rather than requiring all approved changes to be merged in by hand by the project maintainer.
For information about how to install and use Gerrit, refer to the documentation.
Our canonical Git repository is located on googlesource.com. There is a mirror of the repository on Github.
Please report bugs on the issue tracker.
Gerrit is the work of hundreds of contributors. We appreciate your help!
Please read the contribution guidelines.
Note that we do not accept Pull Requests via the Github mirror.
The IRC channel on freenode is #gerrit. An archive is available at: echelog.com.
The Developer Mailing list is repo-discuss on Google Groups.
Gerrit is provided under the Apache License 2.0.
Install Buck and run the following:
git clone --recursive https://gerrit.googlesource.com/gerrit cd gerrit && buck build release
The instruction how to configure GerritForge/BinTray repositories is here
On Debian/Ubuntu run:
apt-get update & apt-get install gerrit=<version>-<release>
NOTE: release is a counter that starts with 1 and indicates the number of packages that have been released with the same version of the software.
On CentOS/RedHat run:
yum clean all && yum install gerrit-<version>[-<release>]
NOTE: release is optional. Last released package of the version is installed if the release number is omitted.