Google Git
Sign in
chromium / chromium / src / b8c3292e220534eeead068f5a6fd3eab783e5c07
commitb8c3292e220534eeead068f5a6fd3eab783e5c07[log] [tgz]
authorChristian Dullweber <dullweber@chromium.org>Thu Sep 10 10:36:42 2020
committerCommit Bot <commit-bot@chromium.org>Thu Sep 10 10:36:42 2020
tree0eeac50695d7f5780ea88bd0e96a6f8cf1151f6e
parent62e39b6472dfaab0d3258d1ded02888cd435a239 [diff]
Show favicon in PageInfo

Fetch a favicon for the current page and display it in the new PageInfo
UI. Use fallback icon when no icon is available.

Also fix a failing assert with the long click callback.

Screenshot: https://crbug.com/1077766#c30
Bug: 1077766
Change-Id: Ia1a911fe9d06c4c1bc30f9721102253b535294e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390320
Reviewed-by: Ehimare Okoyomon <eokoyomon@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#805687}
8 files changed
tree: 0eeac50695d7f5780ea88bd0e96a6f8cf1151f6e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.