commit | 8059e6f2afcbc676ec1e5c9a6dbd6ad593fa6d30 | [log] [tgz] |
---|---|---|
author | Vadim Shtayura <vadimsh@chromium.org> | Sun Feb 10 23:12:51 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Sun Feb 10 23:12:51 2019 |
tree | d3d2440498a59b9eb5acc58cacf8463293e05381 | |
parent | 6bf287fda0e1e61bccd2a6b8dfc0dc308a2bb043 [diff] |
[lucicfg] Stop returning graph.node from 'add_node'. graph.node objects aren't really supposed to be used while the graph is under construction. This is a cleanup in preparation for making various declarations return graph.key objects. It will be needed for Milo and CQ declarations, e.g. to allow milo.console( name = 'ci-console', title = 'CI Console', builder_entries = [ milo.builder_entry_spec( builder = 'Linux CI builder', category = 'infra', short_name = 'lnx', ), ], ) Also remove 'go:generate goimports -w .' from crostesting protos' generate.go. It causes non-null diff on *.pb.go even if nothing is touched. R=tandrii@chromium.org, nodir@chromium.org BUG=833946 Change-Id: Icd6a8e2040afa93b3b5c87c189c81e7a9bdc5811 Reviewed-on: https://chromium-review.googlesource.com/c/1462509 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:
fetch infra cd infra/go eval `./env.py` cd src/go.chromium.org/luci
Contributing uses the same flow as Chromium contributions.