[lucicfg] Stop returning graph.node from 'add_node'.

graph.node objects aren't really supposed to be used while the graph is under
construction.

This is a cleanup in preparation for making various declarations return
graph.key objects. It will be needed for Milo and CQ declarations, e.g. to allow

   milo.console(
       name = 'ci-console',
       title = 'CI Console',

       builder_entries = [
           milo.builder_entry_spec(
               builder = 'Linux CI builder',
               category = 'infra',
               short_name = 'lnx',
           ),
       ],
   )

Also remove 'go:generate goimports -w .' from crostesting protos' generate.go.
It causes non-null diff on *.pb.go even if nothing is touched.

R=tandrii@chromium.org, nodir@chromium.org
BUG=833946

Change-Id: Icd6a8e2040afa93b3b5c87c189c81e7a9bdc5811
Reviewed-on: https://chromium-review.googlesource.com/c/1462509
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
6 files changed
tree: d3d2440498a59b9eb5acc58cacf8463293e05381
  1. appengine/
  2. auth/
  3. buildbucket/
  4. cipd/
  5. client/
  6. common/
  7. config/
  8. cq/
  9. dm/
  10. examples/
  11. gce/
  12. grpc/
  13. hardcoded/
  14. infra/
  15. logdog/
  16. luci_notify/
  17. lucicfg/
  18. lucictx/
  19. machine-db/
  20. milo/
  21. mmutex/
  22. mp/
  23. scheduler/
  24. scripts/
  25. server/
  26. starlark/
  27. swarming/
  28. tokenserver/
  29. tools/
  30. tumble/
  31. vpython/
  32. web/
  33. .gitattributes
  34. .travis.yml
  35. AUTHORS
  36. codereview.settings
  37. CONTRIBUTING.md
  38. CONTRIBUTORS
  39. LICENSE
  40. OWNERS
  41. pre-commit-go.yml
  42. PRESUBMIT.py
  43. README.md
README.md

luci-go: LUCI services and tools in Go

GoDoc

Installing

LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:

fetch infra
cd infra/go
eval `./env.py`
cd src/go.chromium.org/luci

Contributing

Contributing uses the same flow as Chromium contributions.