Google Git
Sign in
chromium / chromium / src / 81bf40a0a17d3150fd5890be9921e9926bd8bdf9
commit81bf40a0a17d3150fd5890be9921e9926bd8bdf9[log] [tgz]
authorKenneth Russell <kbr@chromium.org>Mon Oct 02 22:24:28 2017
committerKenneth Russell <kbr@chromium.org>Mon Oct 02 22:24:28 2017
tree7b07ac23a9775fb7efb1a2f435fe401331b2578b
parent4ac23273c5ea12378187c19616e3b1071da8759c [diff]
Handle invalid format/type in texture uploading when FlipY/PremultiplyAlpha is set.

Currently if uploading from ArrayBuffer, NOTREACHED() will be hit in such situations
and in Release build, after hitting NOTREACHED() statement, unintended code path is taken.

BUG=765469
TEST=webgl_conformance
R=kbr@chromium.org
TBR=zmo@chromium.org

(cherry picked from commit 73ac8f4a66c057b6b22a1c2c6e042c77ef39450d)

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Icf1ab03723b6c13595bd6c4dbc4e5fa40fdf9d96
Reviewed-on: https://chromium-review.googlesource.com/685487
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#504568}
Reviewed-on: https://chromium-review.googlesource.com/696284
Cr-Commit-Position: refs/branch-heads/3202@{#554}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
2 files changed
tree: 7b07ac23a9775fb7efb1a2f435fe401331b2578b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. breakpad/
  7. build/
  8. build_overrides/
  9. cc/
  10. chrome/
  11. chrome_elf/
  12. chromecast/
  13. chromeos/
  14. cloud_print/
  15. components/
  16. content/
  17. courgette/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. mash/
  33. media/
  34. mojo/
  35. native_client_sdk/
  36. net/
  37. pdf/
  38. ppapi/
  39. printing/
  40. remoting/
  41. rlz/
  42. sandbox/
  43. sdch/
  44. services/
  45. skia/
  46. sql/
  47. storage/
  48. styleguide/
  49. testing/
  50. third_party/
  51. tools/
  52. ui/
  53. url/
  54. .clang-format
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. AUTHORS
  62. BUILD.gn
  63. CODE_OF_CONDUCT.md
  64. codereview.settings
  65. DEPS
  66. ENG_REVIEW_OWNERS
  67. LICENSE
  68. LICENSE.chromium_os
  69. OWNERS
  70. PRESUBMIT.py
  71. PRESUBMIT_test.py
  72. PRESUBMIT_test_mocks.py
  73. README.md
  74. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .