commit | 81ccbd091d7cecd8200a1c6dd00927815b4b01ae | [log] [tgz] |
---|---|---|
author | Kevin Chowski <chowski@chromium.org> | Thu Mar 18 19:19:41 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Mar 18 19:19:41 2021 |
tree | ebaea97a3ac6bdbd15c744d1a09a19bebb6c7e76 | |
parent | 0cb07c49eac396c0f74b5e5c688ca0471b7ed275 [diff] |
Pinpoint server: support ListJobs' filter argument. Also includes a (very simple) unit test for ListJobs, relying on some semi-fake data from a test ListJobs query I ran. Change-Id: I6c51cbabf394454098c5787c553ab47e3f528692 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2768560 Commit-Queue: Kevin Chowski <chowski@google.com> Auto-Submit: Kevin Chowski <chowski@google.com> Reviewed-by: Dean Berris <dberris@chromium.org> Cr-Commit-Position: refs/heads/master@{#39491}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.