blob: a5c6e3f44ebc6eeb294a93531bf16b6275998bff [file] [log] [blame]
# Copyright 2017 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""Classes for merging web tests results directories together.
This is split into three parts:
* Generic code to merge JSON data together.
* Generic code to merge directories together.
* Code to specifically merge the web tests result data together.
The JSON data merger will recursively merge dictionaries by default.
* Helper functions can be provided to do more complex merging.
* Helper are called when a given Match object returns true for a given key or
value.
The directory merger will recursively merge the contents of directories.
* Helper functions can be provided to deal with merging specific file objects.
* Helper functions are called when a given Match object returns true for the
filenames.
* The default helper functions only merge if file contents match or the file
only exists in one input directory.
The quickest way to understand how the mergers, helper functions and match
objects work together is to look at the unit tests.
"""
import argparse
import collections
import json
import logging
import os
import pprint
import re
import shutil
import tempfile
import types
from blinkpy.common.system.filesystem import FileSystem
from blinkpy.common.system.log_utils import configure_logging
_log = logging.getLogger(__name__)
# The output JSON has the following arguments overwritten with a value from
# build properties. This occurs when '--build-properties' argument is provided
# and is mainly used when merging on build bots to provide better information
# about the build to the test results server.
# Format is a list of ('result json key', 'build property key').
RESULTS_JSON_VALUE_OVERRIDE_WITH_BUILD_PROPERTY = [
("build_number", "buildnumber"),
("builder_name", "buildername"),
("chromium_revision", "got_revision_cp"),
]
# Classes for recursively merging a JSON like dictionary together.
# ------------------------------------------------------------------------
def join_name(prefix, name):
return "%s:%s" % (prefix, name)
class Match(object):
"""Base class for matching objects."""
def __call__(self, obj, name=None):
return False
class TypeMatch(Match):
"""Match based on instance of given types."""
def __init__(self, *match_types):
self.types = match_types
def __call__(self, obj, name=None):
return isinstance(obj, self.types)
class NameRegexMatch(Match):
"""Match based on regex being found in name.
Use start line (^) and end of line ($) anchors if you want to match on
exact name.
"""
def __init__(self, regex):
self.regex = re.compile(regex)
def __call__(self, obj, name=None):
if name is None:
return False
return self.regex.search(name) is not None
class ValueMatch(Match):
"""Match based on equaling a given value."""
def __init__(self, value):
self.value = value
def __call__(self, obj, name=None):
return obj == self.value
class MergeFailure(Exception):
"""Base exception for merge failing."""
def __init__(self, msg, name, objs):
emsg = (
"Failure merging {name}: "
" {msg}\nTrying to merge {objs}."
).format(
name=name,
msg=msg,
objs=objs,
)
Exception.__init__(self, emsg)
@classmethod
def assert_type_eq(cls, name, objs):
obj_0 = objs[0]
for obj_n in objs[1:]:
if type(obj_0) != type(obj_n):
raise cls("Types don't match", name, (obj_0, obj_n))
class Merger(object):
"""Base class for merger objects."""
def __init__(self):
self.helpers = []
def add_helper(self, match_func, merge_func):
"""Add function which merges values.
match_func and merge_func are dependent on the merger object type.
When the function returns true, the merge_func will be called.
Helpers are searched in last added, first checked order. This allows
more specific helpers to be added after more generic helpers.
"""
self.helpers.append((match_func, merge_func))
class JSONMerger(Merger):
"""Merge JSON-like objects.
For adding helpers;
match_func is a function of form
def f(obj, name=None) -> bool
When the function returns true, the merge_func will be called.
merge_func is a function of the form
def f(list_of_objs, name=None) -> obj_merged
Merge functions should *never* modify the input arguments.
"""
def __init__(self):
Merger.__init__(self)
self.add_helper(
TypeMatch(types.ListType, types.TupleType), self.merge_listlike)
self.add_helper(
TypeMatch(types.DictType), self.merge_dictlike)
def fallback_matcher(self, objs, name=None):
raise MergeFailure(
"No merge helper found!", name, objs)
def merge_equal(self, objs, name=None):
"""Merge equal objects together."""
obj_0 = objs[0]
for obj_n in objs[1:]:
if obj_0 != obj_n:
raise MergeFailure(
"Unable to merge!", name, (obj_0, obj_n))
return obj_0
def merge_listlike(self, lists, name=None): # pylint: disable=unused-argument
"""Merge things which are "list like" (tuples, lists, sets)."""
MergeFailure.assert_type_eq(name, lists)
output = list(lists[0])
for list_n in lists[1:]:
output.extend(list_n)
return lists[0].__class__(output)
def merge_dictlike(self, dicts, name=None, order_cls=collections.OrderedDict):
"""Merge things which are dictionaries.
Args:
dicts (list of dict): Dictionary like objects to merge (should all
be the same type).
name (str): Name of the objects being merged (used for error
messages).
order_cls: Dict like object class used to produce key ordering.
Defaults to collections.OrderedDict which means all keys in
dicts[0] come before all keys in dicts[1], etc.
Returns:
dict: Merged dictionary object of same type as the objects in
dicts.
"""
MergeFailure.assert_type_eq(name, dicts)
dict_mid = order_cls()
for dobj in dicts:
for key in dobj:
dict_mid.setdefault(key, []).append(dobj[key])
dict_out = dicts[0].__class__({})
for k, v in dict_mid.iteritems():
assert v
if len(v) == 1:
dict_out[k] = v[0]
elif len(v) > 1:
dict_out[k] = self.merge(v, name=join_name(name, k))
return dict_out
def merge(self, objs, name=""):
"""Generic merge function.
name is a string representing the current key value separated by
semicolons. For example, if file.json had the following;
{'key1': {'key2': 3}}
Then the name of the value 3 is 'file.json:key1:key2'
"""
objs = [o for o in objs if o is not None]
if not objs:
return None
MergeFailure.assert_type_eq(name, objs)
# Try the merge helpers.
for match_func, merge_func in reversed(self.helpers):
for obj in objs:
if match_func(obj, name):
return merge_func(objs, name=name)
return self.fallback_matcher(objs, name=name)
# Classes for recursively merging a directory together.
# ------------------------------------------------------------------------
class FilenameRegexMatch(object):
"""Match based on name matching a regex."""
def __init__(self, regex):
self.regex = re.compile(regex)
def __call__(self, filename, to_merge):
return self.regex.search(filename) is not None
def __str__(self):
return "FilenameRegexMatch(%r)" % self.regex.pattern
__repr__ = __str__
class MergeFiles(object):
"""Base class for things which merge files."""
def __init__(self, filesystem):
assert filesystem
self.filesystem = filesystem
def __call__(self, out_filename, to_merge):
raise NotImplementedError()
class MergeFilesOne(MergeFiles):
"""Dummy function which 'merges' a single file into output."""
def __call__(self, out_filename, to_merge):
assert len(to_merge) == 1
self.filesystem.copyfile(to_merge[0], out_filename)
class MergeFilesMatchingContents(MergeFiles):
"""Merge if the contents of each files given matches exactly."""
def __call__(self, out_filename, to_merge):
data = self.filesystem.read_binary_file(to_merge[0])
nonmatching = []
for filename in to_merge[1:]:
other_data = self.filesystem.read_binary_file(filename)
if data != other_data:
nonmatching.append(filename)
if nonmatching:
raise MergeFailure(
'\n'.join(
['File contents don\'t match:'] + nonmatching),
out_filename,
to_merge)
self.filesystem.write_binary_file(out_filename, data)
class MergeFilesLinesSorted(MergeFiles):
"""Merge and sort the files of the given files."""
def __call__(self, out_filename, to_merge):
lines = []
for filename in to_merge:
with self.filesystem.open_text_file_for_reading(filename) as f:
lines.extend(f.readlines())
lines.sort()
with self.filesystem.open_text_file_for_writing(out_filename) as f:
f.writelines(lines)
class MergeFilesKeepFiles(MergeFiles):
"""Merge by copying each file appending a number to filename."""
def __call__(self, out_filename, to_merge):
for i, filename in enumerate(to_merge):
self.filesystem.copyfile(filename, "%s_%i" % (out_filename, i))
class MergeFilesJSONP(MergeFiles):
"""Merge JSONP (and JSON) files.
filesystem:
filesystem.FileSystem object.
json_data_merger:
JSONMerger object used for merging the JSON data inside the files.
json_value_data_overrides:
Dictionary of {'key': 'value'} values to override in the resulting
output.
"""
def __init__(self, filesystem, json_data_merger=None, json_data_value_overrides=None):
MergeFiles.__init__(self, filesystem)
self._json_data_merger = json_data_merger or JSONMerger()
self._json_data_value_overrides = json_data_value_overrides or {}
def __call__(self, out_filename, to_merge):
try:
before_0, new_json_data_0, after_0 = self.load_jsonp(
self.filesystem.open_binary_file_for_reading(to_merge[0]))
except ValueError as e:
raise MergeFailure(e.message, to_merge[0], None)
input_data = [new_json_data_0]
for filename_n in to_merge[1:]:
try:
before_n, new_json_data_n, after_n = self.load_jsonp(
self.filesystem.open_binary_file_for_reading(filename_n))
except ValueError as e:
raise MergeFailure(e.message, filename_n, None)
if before_0 != before_n:
raise MergeFailure(
"jsonp starting data from %s doesn't match." % filename_n,
out_filename,
[before_0, before_n])
if after_0 != after_n:
raise MergeFailure(
"jsonp ending data from %s doesn't match." % filename_n,
out_filename,
[after_0, after_n])
input_data.append(new_json_data_n)
output_data = self._json_data_merger.merge(input_data, name=out_filename)
output_data.update(self._json_data_value_overrides)
self.dump_jsonp(
self.filesystem.open_binary_file_for_writing(out_filename),
before_0, output_data, after_0)
@staticmethod
def load_jsonp(fd):
"""Load a JSONP file and return the JSON data parsed.
JSONP files have a JSON data structure wrapped in a function call or
other non-JSON data.
"""
in_data = fd.read()
begin = in_data.find('{')
end = in_data.rfind('}') + 1
before = in_data[:begin]
data = in_data[begin:end]
after = in_data[end:]
# If just a JSON file, use json.load to get better error message output.
if before == '' and after == '':
fd.seek(0)
json_data = json.load(fd)
else:
json_data = json.loads(data)
return before, json_data, after
@staticmethod
def dump_jsonp(fd, before, json_data, after):
"""Write a JSONP file.
JSONP files have a JSON data structure wrapped in a function call or
other non-JSON data.
"""
fd.write(before)
fd.write(
re.subn(
'\\s+\n', '\n',
json.dumps(json_data, indent=2, sort_keys=True))[0])
fd.write(after)
class DeferredPrettyPrint(object):
"""Defer pretty print generation until it actually is getting produced.
Needed so that we don't do this work if the logging statement is disabled.
"""
def __init__(self, *args, **kw):
self.args = args
self.kw = kw
def __str__(self):
return pprint.pformat(*self.args, **self.kw)
class DirMerger(Merger):
"""Merge directory of files.
For adding helpers;
match_func is a function of form
def f(output filename, list(input filepaths to merge)) -> bool
merge_func is a function of the form
def f(output filename, list(input filepaths to merge))
"""
def __init__(self, filesystem=None):
Merger.__init__(self)
self.filesystem = filesystem or FileSystem()
# Default to just checking the file contents matches.
self.add_helper(lambda *args: True, MergeFilesMatchingContents(self.filesystem))
# Copy the file it it's the only one.
self.add_helper(lambda _, to_merge: len(to_merge) == 1, MergeFilesOne(self.filesystem))
def merge(self, output_dir, to_merge_dirs):
output_dir = self.filesystem.realpath(self.filesystem.abspath(output_dir))
merge_dirs = []
# Normalize the given directory values.
for base_dir in to_merge_dirs:
merge_dirs.append(self.filesystem.realpath(self.filesystem.abspath(base_dir)))
merge_dirs.sort()
_log.debug("Merging following paths:")
_log.debug(DeferredPrettyPrint(merge_dirs))
# Walk all directories and create a list of files found in any. The
# result will look like;
# ----
# files = {
# 'path to file common between shards': [
# 'directory to shard A which contains file',
# 'directory to shard B which contains file',
# ...],
# ...}
# ----
files = {}
for base_dir in merge_dirs:
for dir_path, _, filenames in self.filesystem.walk(base_dir):
assert dir_path.startswith(base_dir)
for f in filenames:
# rel_file is the path of f relative to the base directory
rel_file = self.filesystem.join(dir_path, f)[len(base_dir) + 1:]
files.setdefault(rel_file, []).append(base_dir)
# Go through each file and try to merge it.
# partial_file_path is the file relative to the directories.
for partial_file_path, in_dirs in sorted(files.iteritems()):
out_path = self.filesystem.join(output_dir, partial_file_path)
if self.filesystem.exists(out_path):
raise MergeFailure(
'File %s already exist in output.', out_path, None)
dirname = self.filesystem.dirname(out_path)
if not self.filesystem.exists(dirname):
self.filesystem.maybe_make_directory(dirname)
to_merge = [self.filesystem.join(d, partial_file_path) for d in in_dirs]
# If we're only 'merging' one file, don't output to the log. Not a
# very useful message.
if len(to_merge) > 1:
_log.debug("Creating merged %s from %s", out_path, to_merge)
for match_func, merge_func in reversed(self.helpers):
if not match_func(partial_file_path, to_merge):
continue
merge_func(out_path, to_merge)
break
# Classes specific to merging web test results directory.
# ------------------------------------------------------------------------
class JSONTestResultsMerger(JSONMerger):
"""Merger for the 'json test result' format.
The JSON format is described at
https://dev.chromium.org/developers/the-json-test-results-format
allow_unknown_if_matching:
Allow unknown keys found in multiple files if the value matches in all.
"""
def __init__(self, allow_unknown_if_matching=False):
JSONMerger.__init__(self)
self.allow_unknown_if_matching = allow_unknown_if_matching
# Most of the JSON file can be merged by the default merger but we need
# some extra helpers for some special fields.
# These keys are constants which should be the same across all the shards.
matching = [
':builder_name$',
':build_number$',
':chromium_revision$',
':flag_name$',
':has_pretty_patch$',
':has_wdiff$',
':path_delimiter$',
':random_order_seed$',
':version$',
]
for match_name in matching:
self.add_helper(
NameRegexMatch(match_name),
self.merge_equal)
# These keys are accumulated sums we want to add together.
addable = [
':fixable$',
':num_flaky$',
':num_passes$',
':num_regressions$',
':skipped$',
':skips$',
# All keys inside the num_failures_by_type entry.
':num_failures_by_type:',
]
for match_name in addable:
self.add_helper(
NameRegexMatch(match_name),
lambda o, name=None: sum(o))
# If any shard is interrupted, mark the whole thing as interrupted.
self.add_helper(
NameRegexMatch(':interrupted$'),
lambda o, name=None: bool(sum(o)))
# Web test directory value is randomly created on each shard, so
# clear it.
self.add_helper(
NameRegexMatch(':layout_tests_dir$'),
lambda o, name=None: None)
# seconds_since_epoch is the start time, so we just take the earliest.
self.add_helper(
NameRegexMatch(':seconds_since_epoch$'),
lambda o, name=None: min(*o))
def fallback_matcher(self, objs, name=None):
if self.allow_unknown_if_matching:
result = self.merge_equal(objs, name)
_log.warning('Unknown value %s, accepting anyway as it matches.', name)
return result
return JSONMerger.fallback_matcher(self, objs, name)
class WebTestDirMerger(DirMerger):
"""Merge web test result directory."""
def __init__(self, filesystem=None,
results_json_value_overrides=None,
results_json_allow_unknown_if_matching=False):
DirMerger.__init__(self, filesystem)
# JSON merger for non-"result style" JSON files.
basic_json_data_merger = JSONMerger()
basic_json_data_merger.fallback_matcher = basic_json_data_merger.merge_equal
self.add_helper(
FilenameRegexMatch(r'\.json$'),
MergeFilesJSONP(self.filesystem, basic_json_data_merger))
# access_log and error_log are httpd log files which are sortable.
self.add_helper(
FilenameRegexMatch(r'access_log\.txt$'),
MergeFilesLinesSorted(self.filesystem))
self.add_helper(
FilenameRegexMatch(r'error_log\.txt$'),
MergeFilesLinesSorted(self.filesystem))
# pywebsocket files aren't particularly useful, so just save them.
self.add_helper(
FilenameRegexMatch(r'pywebsocket\.ws\.log-.*-err\.txt$'),
MergeFilesKeepFiles(self.filesystem))
# These JSON files have "result style" JSON in them.
results_json_file_merger = MergeFilesJSONP(
self.filesystem,
JSONTestResultsMerger(
allow_unknown_if_matching=results_json_allow_unknown_if_matching),
json_data_value_overrides=results_json_value_overrides or {})
self.add_helper(
FilenameRegexMatch(r'failing_results\.json$'),
results_json_file_merger)
self.add_helper(
FilenameRegexMatch(r'full_results\.json$'),
results_json_file_merger)
self.add_helper(
FilenameRegexMatch(r'output\.json$'),
results_json_file_merger)
self.add_helper(
FilenameRegexMatch(r'full_results_jsonp\.js$'),
results_json_file_merger)
# ------------------------------------------------------------------------
def ensure_empty_dir(fs, directory, allow_existing, remove_existing):
"""Ensure an empty directory exists.
Args:
allow_existing (bool): Allow the empty directory to already exist.
remove_existing (bool): Remove the contents if the directory
already exists.
"""
if not fs.exists(directory):
fs.maybe_make_directory(directory)
return
logging.warning('Output directory exists %r', directory)
if not allow_existing:
raise IOError(
('Output directory %s exists!\n'
'Use --allow-existing-output-directory to continue') % directory)
if remove_existing and not fs.remove_contents(directory):
raise IOError(
('Unable to remove output directory %s contents!\n'
'See log output for errors.') % directory)
def main(argv):
parser = argparse.ArgumentParser()
parser.description = """\
Merges sharded web test results into a single output directory.
"""
parser.epilog = """\
If a post merge script is given, it will be run on the resulting merged output
directory. The script will be given the arguments plus
'--results_dir <output_directory>'.
"""
parser.add_argument(
'-v', '--verbose', action='store_true',
help='Output information about merging progress.')
parser.add_argument(
'--results-json-override-value',
nargs=2, metavar=('KEY', 'VALUE'), default=[],
action='append',
help='Override the value of a value in the result style JSON file '
'(--result-jsons-override-value layout_test_dirs /tmp/output).')
parser.add_argument(
'--results-json-allow-unknown-if-matching',
action='store_true', default=False,
help='Allow unknown values in the result.json file as long as the '
'value match on all shards.')
parser.add_argument(
'--output-directory',
help='Directory to create the merged results in.')
parser.add_argument(
'--allow-existing-output-directory',
action='store_true', default=False,
help='Allow merging results into a directory which already exists.')
parser.add_argument(
'--remove-existing-output-directory',
action='store_true', default=False,
help='Remove merging results into a directory which already exists.')
parser.add_argument(
'--input-directories', nargs='+',
help='Directories to merge the results from.')
# Swarming Isolated Merge Script API
# script.py \
# --build-properties /s/build.json \
# --output-json /tmp/output.json \
# --task-output-dir /path/to/task/output/dir \
# shard0/output.json \
# shard1/output.json
parser.add_argument(
'-o', '--output-json',
help='(Swarming Isolated Merge Script API) Output JSON file to create.')
parser.add_argument(
'--build-properties',
help='(Swarming Isolated Merge Script API) Build property JSON file provided by recipes.')
parser.add_argument(
'--task-output-dir',
help='(Swarming Isolated Merge Script API) Directory containing all swarming task results.')
parser.add_argument(
'--results-json-override-with-build-property',
nargs=2, metavar=('RESULT_JSON_KEY', 'BUILD_PROPERTY_KEY'), default=[],
action='append',
help='Override the value of a value in the result style JSON file '
'(--result-jsons-override-value layout_test_dirs /tmp/output).')
parser.add_argument(
'--summary-json',
help='(Swarming Isolated Merge Script API) Summary of shard state running on swarming.'
'(Output of the swarming.py collect --task-summary-json=XXX command.)')
# Script to run after merging the directories together. Normally used with archive_layout_test_results.py
# scripts/slave/chromium/archive_layout_test_results.py \
# --results-dir /b/rr/tmpIcChUS/w/layout-test-results \
# --build-dir /b/rr/tmpIcChUS/w/src/out \
# --build-number 3665 \
# --builder-name 'WebKit Linux - RandomOrder' \
# --gs-bucket gs://chromium-layout-test-archives \
# --staging-dir /b/c/chrome_staging \
# --slave-utils-gsutil-py-path /b/rr/tmpIcChUS/rw/scripts/slave/.recipe_deps/depot_tools/gsutil.py
# in dir /b/rr/tmpIcChUS/w
parser.add_argument(
'--post-merge-script',
nargs='*',
help='Script to call after the results have been merged.')
# The position arguments depend on if we are using the isolated merge
# script API mode or not.
parser.add_argument(
'positional', nargs='*',
help='output.json from shards.')
args = parser.parse_args(argv)
if args.verbose:
logging_level = logging.DEBUG
else:
logging_level = logging.INFO
configure_logging(logging_level=logging_level)
# Map the isolate arguments back to our output / input arguments.
if args.output_json:
logging.info('Running with isolated arguments')
assert args.positional
# TODO(tansell): Once removed everywhere, these lines can be removed.
# For now we just check nobody is supply arguments we didn't expect.
if args.results_json_override_with_build_property:
for result_key, build_prop_key in args.results_json_override_with_build_property:
assert (result_key, build_prop_key) in RESULTS_JSON_VALUE_OVERRIDE_WITH_BUILD_PROPERTY, (
"%s not in %s" % (result_key, RESULTS_JSON_VALUE_OVERRIDE_WITH_BUILD_PROPERTY))
if not args.output_directory:
args.output_directory = os.getcwd()
args.allow_existing_output_directory = True
args.remove_existing_output_directory = True
assert not args.input_directories
args.input_directories = [os.path.dirname(f) for f in args.positional]
args.positional = []
# Allow skipping the --input-directories bit, for example,
# merge_web_test_results.py -o outputdir shard0 shard1 shard2
if args.positional and not args.input_directories:
args.input_directories = args.positional
if not args.output_directory:
args.output_directory = tempfile.mkdtemp(suffix='webkit_layout_test_results.')
assert args.output_directory
assert args.input_directories
results_json_value_overrides = {}
if args.build_properties:
build_properties = json.loads(args.build_properties)
for result_key, build_prop_key in RESULTS_JSON_VALUE_OVERRIDE_WITH_BUILD_PROPERTY:
if build_prop_key not in build_properties:
logging.warn('Required build property key "%s" was not found!', build_prop_key)
continue
results_json_value_overrides[result_key] = build_properties[build_prop_key]
logging.debug('results_json_value_overrides: %r', results_json_value_overrides)
merger = WebTestDirMerger(
results_json_value_overrides=results_json_value_overrides,
results_json_allow_unknown_if_matching=args.results_json_allow_unknown_if_matching)
ensure_empty_dir(
FileSystem(),
args.output_directory,
allow_existing=args.allow_existing_output_directory,
remove_existing=args.remove_existing_output_directory)
merger.merge(args.output_directory, args.input_directories)
merged_output_json = os.path.join(args.output_directory, 'output.json')
if os.path.exists(merged_output_json) and args.output_json:
logging.debug(
'Copying output.json from %s to %s', merged_output_json, args.output_json)
shutil.copyfile(merged_output_json, args.output_json)
if args.post_merge_script:
logging.debug('Changing directory to %s', args.output_directory)
os.chdir(args.output_directory)
post_script = list(args.post_merge_script)
post_script.append('--result-dir', args.output_directory)
logging.info('Running post merge script %r', post_script)
os.execlp(post_script)