| commit | 82607619879e0e403f666fea49c137a2b8611f5c | [log] [tgz] |
|---|---|---|
| author | Vadim Shtayura <vadimsh@chromium.org> | Thu Dec 20 01:15:48 2018 |
| committer | Commit Bot <commit-bot@chromium.org> | Thu Dec 20 01:15:48 2018 |
| tree | a6636401286d99c9bd7e53bfb174777d9946891a | |
| parent | b80eef069891a02c473154e5e85988c1be4b7ab3 [diff] |
[lucicfg] Make graph.key objects introspectable through Starlark. They now have attributes 'container', 'kind', 'id'. This would become useful for implementing rules that behave differently depending on a kind of an object they are related to. For the key [(k1, i1), (k2, i2), (k3, i3)]: 'container' is key [(k1, i1), (k2, i2)] 'kind' is string 'k3' 'id' is string 'i3' Term "container" was chosen to avoid confusion with term "parent", already used in the graph API to denote a different sort of relation. R=nodir@chromium.org, tandrii@chromium.org BUG=833946 Change-Id: I16ea3709b6a2adbff9a9d7f810d1080cd5c48f24 Reviewed-on: https://chromium-review.googlesource.com/c/1385666 Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:
fetch infra cd infra/go eval `./env.py` cd src/go.chromium.org/luci
Contributing uses the same flow as Chromium contributions.