commit | 827abd88b0bfa380419c13c98d22e30cab5d0c82 | [log] [tgz] |
---|---|---|
author | Koji Ishii <kojii@chromium.org> | Mon Nov 05 19:48:49 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Nov 05 19:48:49 2018 |
tree | 155ea2025573067cbbc8df13ce12126dd4eaa415 | |
parent | b653a893e550bb429f0c3131931736e62ef07b68 [diff] |
[LayoutNG] Fix NGInlineNode::MarkLineBoxesDirty This patch fixes MarkLineBoxesDirty to mark correctly when: 1. The changed node has a parent inline box, and 2. is the first child of the parent, and 3. the parent has box fragment (not culled,) and 4. the parent wraps to multiple lines. e.g., <span id="parent" style="background: yellow"> <span id="changed"></span> <br> text </span> In this case, the old code marks the line box that contains the last fragment of #parent because #parent is "previous" of #changed in the pre-order DFS. The marked line box is the one after #changed, and thus we try to reuse changed line. This issue was found by a WIP to apply reusing line boxes in more cases. From the stack, this looks the same as crbug.com/900898. Bug: 636993, 900898 Change-Id: I43d1d8150bfff7e1d9a6572be5a235cbe937caac Reviewed-on: https://chromium-review.googlesource.com/c/1314086 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#605422}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .