commit | 830e31f6b1fcddb8c2ec4abf421c640fdcb437da | [log] [tgz] |
---|---|---|
author | Kevin Chowski <chowski@google.com> | Wed Mar 24 20:04:15 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Mar 24 20:04:15 2021 |
tree | f1b20a09d46256cd9b12a1d069efccd1fbd6bf9d | |
parent | c27f979330975f58687c67d6dbcf5273e3ef0d0e [diff] |
Pinpoint server: add unit test for ScheduleJob. This CL also moves the shouldBeStatusCode helper from the fakelegacy test into a common location for reuse by this package. A future CL will use this assertion more in the server_test. Change-Id: Icc7df3efbfdf43fd699e8072442d724b120a8fa7 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2773444 Commit-Queue: Kevin Chowski <chowski@google.com> Auto-Submit: Kevin Chowski <chowski@google.com> Reviewed-by: Dean Berris <dberris@chromium.org> Cr-Commit-Position: refs/heads/master@{#39694}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.