Google Git
Sign in
chromium / chromium / src / 83a970c898ca173ebeafb9fffc5cec3c84b6b1a3
commit83a970c898ca173ebeafb9fffc5cec3c84b6b1a3[log] [tgz]
authorAlex Kalugin <akalugin@yandex-team.ru>Mon Nov 30 07:05:20 2020
committerCommit Bot <commit-bot@chromium.org>Mon Nov 30 07:05:20 2020
tree2e1b6a01a30b2436d1a9fd3d3c66ceeab12d1c50
parentea612e70d26aec9bb7b25f70a05c5e5dcd2a8c5e [diff]
Fix ServiceWorkerRegistry constructor from old registry.

Properly save data necessary for future ServiceWorkerStorage::Create
calls in ServiceWorkerRegistry c-tor from old registry.
Currently, if you construct ServiceWorkerRegistry R1 from old registry
and then construct another one R2 from R1, then R2 will be broken,
because user_data_directory_, database_task_runner_ and
quota_manager_proxy_ data are lost.
Problem was introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/2477141 ,
before that, data from old ServiceWorkerStorage instance was reused.

Change-Id: I617987a24f265c7cb826dde8f07b377b05f4957c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563459
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#831765}
1 file changed
tree: 2e1b6a01a30b2436d1a9fd3d3c66ceeab12d1c50
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.