Google Git
Sign in
chromium / chromium / src / a2379c66b400c4ce76e7b7016430e45895f983fe
commita2379c66b400c4ce76e7b7016430e45895f983fe[log] [tgz]
authorVictor Costan <pwnall@chromium.org>Fri Dec 04 21:20:58 2020
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Dec 04 21:20:58 2020
tree5c706f3b8a2bd19669f252a04545a659a4b44788
parent923ca485c6534d7cad4744404a1b942aec992d5c [diff]
NativeIO: Minor improvements for NativeIOQuotaClient.

This CL fixes issues I missed while reviewing
https://crrev.com/c/2467899.

* Use base::SequenceChecker instead of making thread-hostile checks. The
  quota client doesn't need to run on the IO thread, it just needs to
  run on the same sequence as NativeIOContext.

* Replace the deprecated DISALLOW_COPY_AND_ASSIGN() macro with deleted
  copy constructor and assignment operator.

* Remove qualifier (storage::QuotaClient::) from QuotaClient callback
  types. This reduces churn when QuotaClient becomes a mojo interface.

* Remove unused GetClientTypeFromOwner() declaration.

* Remove self-#include in header.

No functional changes are introduced.

Bug: 1137788, 1016065
Change-Id: I34f59e128e877358d16f197bc6e6f0ac79de5df3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570318
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Jarryd Goodman <jarrydg@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833862}
2 files changed
tree: 5c706f3b8a2bd19669f252a04545a659a4b44788
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.