commit | 83a8cf9b20150285af625768cdbbffaf4f1518bc | [log] [tgz] |
---|---|---|
author | Nasko Oskov <nasko@chromium.org> | Fri Oct 19 14:58:56 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Oct 19 14:58:56 2018 |
tree | 2eb62a185f0abde91e2b389b8a23264c8f622821 | |
parent | 0d23b5cf0da7631e2d9d4bf53ea4baf48a51c330 [diff] |
Replace OpenURL usage in window.open() with LoadURLWithParams. The current window.open() implementation on the browser side is using OpenURL to navigate when the opener is suppressed (e.g. 'noopener') and URL is specified. This results in the navigation being sent up to the embedder and come back to content. Since the default parameters being constructed should not cause the embedder to make any changes to the navigation, it should be safe to skip the extra code and directly navigate the new window. This CL adds LoadURLParams storage to WebContentsImpl and implements all navigations of window.open() that are started browser process side to use NavigationController::LoadURLWithParams. It effectively short-circuits the unnecessary trip to the embedder. Bug: 882053 Change-Id: I09120397f3a6e7856e76ba0448d0bdff807f7628 Reviewed-on: https://chromium-review.googlesource.com/c/1286194 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#601148}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .