commit | 5cf4b8b13ed518472038170f8de9db2f6c258fe4 | [log] [tgz] |
---|---|---|
author | Tal Pressman <talp@chromium.org> | Thu Jan 28 07:19:48 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jan 28 07:19:48 2021 |
tree | 910fa7f858b13f89392764d3a6a434224abeadf1 | |
parent | a526ba083153af738971ec58b43739c54810a111 [diff] |
Revert "Merge ContextLifecycleNotifier into MojoBindingContext." This reverts commit 03ad8ab3ca36d5574cf107251d0f47a867288975. Reason for revert: After some more discussion and thought, we have reached the conclusion that many users of ContextLifecycleNotifier/Observer don't care about the Mojo capabilities introduced by MojoBindingContext. As such, this CL reverts the merging of the 2 classes, with future CLs making MojoBindingContext extend ContextLifecycleNotifier. Original change's description: > Merge ContextLifecycleNotifier into MojoBindingContext. > > Following the discussions on platform-architecture-dev[1], this CL > expands MojoBindingContext's responsibility to include context lifecycle > notifications which were previously in ContextLifecycleNotifier. > > [1] https://groups.google.com/a/chromium.org/g/platform-architecture-dev/c/_7Ybv_RLgic > > Change-Id: Icdcc2a59bf0580b919d1dbb015a45bfd184583b3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596279 > Commit-Queue: Tal Pressman <talp@google.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844692} TBR=haraken@chromium.org,kouhei@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,talp@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I5c2e3e7f08d20a4a4a40bd3d5f9bc863507a26b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2654765 Reviewed-by: Tal Pressman <talp@google.com> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Tal Pressman <talp@google.com> Cr-Commit-Position: refs/heads/master@{#848005}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.