commit | 848c86e3e858154175944198db821e80ec7ebfc5 | [log] [tgz] |
---|---|---|
author | Michael Moss <mmoss@google.com> | Thu May 03 23:05:50 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu May 03 23:13:38 2018 |
tree | 7533393a09b175bae9c7814595883b6def3c058e | |
parent | ea50265aefdf0a262fdf315c2f4193345f6cefca [diff] |
Make 'gclient_gn_args*' handling consistent between sync and flatten. Previously, 'gclient sync' would process "gn_args" settings in any recursed DEPS files, potentially producing multiple output files or conflicting output files, but 'gclient flatten' would only ever include one set of "gn_args" settings in the flattened output, and only if they occurred in the top-level DEPS file. This makes 'gclient sync' and 'gclient flatten' more consistent by restricting them both to a single instance of those setting, and requiring those setting to be defined either in the top-level DEPS file, or in a recursedeps file specificed by the new 'gclient_gn_args_from' setting. R=dpranke@google.com, ehmaldonado@google.com Bug: 825063 Change-Id: If90d952e47367c50b36daade16a26b29aec0c9db Reviewed-on: https://chromium-review.googlesource.com/1039870 Reviewed-by: Michael Moss <mmoss@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
To update cpplint.py, please submit the change upstream first at https://github.com/google/styleguide/tree/gh-pages/cpplint then copy it down.