| commit | 848d87add663bb265a035d2a166728fce25c17e2 | [log] [tgz] |
|---|---|---|
| author | Vadim Shtayura <vadimsh@chromium.org> | Mon Feb 11 23:17:27 2019 |
| committer | Commit Bot <commit-bot@chromium.org> | Mon Feb 11 23:17:27 2019 |
| tree | b54e8b30f3fb3926a81ce6b6fc7fb469bcd3aec0 | |
| parent | b88e1645d680d0517aa1289c3b844cd2d0d0c27f [diff] |
[lucicfg] Allow calling rules inline right where they are referenced.
Rules now return graph.keyset(...) objects that are accepted by other rules.
This is now allowed (but subject to all existing constraints, e.g. name
uniqueness):
core.builder(
...
recipe = core.recipe(
...
),
)
This is in preparation for adding Milo and CQ rules that use "annotated"
many-to-many relations (milo groups <-> builders, CQ ref sets <-> builders).
Each such annotated relation would be represented by a graph node. Requiring
all of them to be declared at the top scope leads to a lot of unnecessary
repetition.
R=tandrii@chromium.org, nodir@chromium.org
BUG=833946
Change-Id: I1bb742d7973ca7f3c419fa843e42ff0e6c965aa5
Reviewed-on: https://chromium-review.googlesource.com/c/1462540
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
LUCI Go code is meant to be worked on from an Chromium infra.git checkout, which enforces packages versions and Go toolchain version. First get fetch via depot_tools.git then run:
fetch infra cd infra/go eval `./env.py` cd src/go.chromium.org/luci
Contributing uses the same flow as Chromium contributions.