| commit | 8496468f39f1af06f5f0557b999636928487b421 | [log] [tgz] |
|---|---|---|
| author | mkwst <mkwst@chromium.org> | Tue Dec 08 09:54:13 2015 |
| committer | Commit bot <commit-bot@chromium.org> | Tue Dec 08 09:55:28 2015 |
| tree | bdc035e3017d7a3694e005b2f31696fd0528ae47 | |
| parent | d8c4ae6dbfcc55ef93263bd99bc40645e90822a6 [diff] |
Revert of Enable Control Flow Integrity for the official Linux Chrome. (patchset #1 id:1 of https://codereview.chromium.org/1502373003/ ) Reason for revert: Speculative revert to see if this resolves dependency issues on the official builder. """ Huh! It appears that dpkg-shlibdeps (http://man.he.net/man1/dpkg-shlibdeps) takes a look at the undefined symbols in the binary, looks at their version and generates the requirement, like "libdbus-1-3 (>= 1.2.14)". If some code was eliminated due to full-program optimization, the number of undefined symbols could reduce, and the requirement could become weaker, like "libdbus-1-3 (>= 1.1.4)". """ BUG=567637 Original issue's description: > Enable Control Flow Integrity for the official Linux Chrome. > > This CL turns on CFI, a security check: > https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity > http://clang.llvm.org/docs/ControlFlowIntegrity.html > > This feature enables LTO (Link-Time Optimization) builds, which slow down the linker by 3x-4x. > CFI also comes with a code size overhead of about 7%-9%. The runtime CPU cost is less than 1%, > and should not be an issue. > > BUG=chromium:464797 > Intent to Implement thread: > https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pbJqt6ccMII/7iJC2oklCAAJ > > This is a third attempt to land the CL. Previous attempts: > https://codereview.chromium.org/1501593003/ > https://codereview.chromium.org/1393283005/ > > All issues discovered by the previous attempt are resolved at this point. > > Committed: https://crrev.com/2e8ed4750b26923558b4754de4fd7f4cae3399e8 > Cr-Commit-Position: refs/heads/master@{#363677} TBR=thakis@chromium.org,krasin@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:464797 Review URL: https://codereview.chromium.org/1502133004 Cr-Commit-Position: refs/heads/master@{#363778}