Google Git
Sign in
chromium / chromium / tools / depot_tools / 851532894fe976bfe62e6c3ba15de4904c6f3121
commit851532894fe976bfe62e6c3ba15de4904c6f3121[log] [tgz]
authorEdward Lemur <ehmaldonado@google.com>Fri Feb 14 22:06:29 2020
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Feb 14 22:06:29 2020
tree6420ceb89a6307c17e722b90a1e5d48c654f0462
parentc4243361bbb66cf940da202ff55fcdd625ae60b1 [diff]
git-cl: Use scm.GIT.{Get,Set}BranchConfig and {Get,Set}BranchRef instead of git calls.

scm.GIT functions are tested, and using them makes it easier to mock
git calls on git-cl tests.

Bug: 1051631
Change-Id: If067aa3f71b7478cafd7985d3020dacc0c6a41c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2055464
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
4 files changed
tree: 6420ceb89a6307c17e722b90a1e5d48c654f0462
  1. bootstrap/
  2. fetch_configs/
  3. git-templates/
  4. infra/
  5. man/
  6. python-bin/
  7. recipes/
  8. testing_support/
  9. tests/
  10. third_party/
  11. win_toolchain/
  12. zsh-goodies/
  13. cbuildbot ⇨ cros
  14. chrome_set_ver ⇨ cros
  15. cros_sdk ⇨ cros
  16. .gitattributes
  17. .gitignore
  18. .style.yapf
  19. .vpython
  20. .vpython3
  21. auth.py
  22. autoninja
  23. autoninja.bat
  24. autoninja.py
  25. bb
  26. bb.bat
  27. bootstrap_python3
  28. breakpad.py
  29. cipd
  30. cipd.bat
  31. cipd.ps1
  32. cipd_bin_setup.bat
  33. cipd_bin_setup.sh
  34. cipd_client_version
  35. cipd_client_version.digests
  36. cipd_manifest.txt
  37. cipd_manifest.versions
  38. cit
  39. cit.bat
  40. cit.py
  41. clang-format
  42. clang-format.bat
  43. clang_format.py
  44. clang_format_merge_driver
  45. clang_format_merge_driver.bat
  46. clang_format_merge_driver.py
  47. codereview.settings
  48. compile_single_file
  49. compile_single_file.bat
  50. compile_single_file.py
  51. cpplint.bat
  52. cpplint.py
  53. cpplint_chromium.py
  54. cros
  55. CROS_OWNERS
  56. crosjobs
  57. dart_format.py
  58. detect_host_arch.py
  59. download_from_google_storage
  60. download_from_google_storage.bat
  61. download_from_google_storage.py
  62. ensure_bootstrap
  63. fetch
  64. fetch.bat
  65. fetch.py
  66. fix_encoding.py
  67. gclient
  68. gclient-new-workdir.py
  69. gclient.bat
  70. gclient.py
  71. gclient_completion.sh
  72. gclient_eval.py
  73. gclient_paths.py
  74. gclient_scm.py
  75. gclient_utils.py
  76. gerrit_client.py
  77. gerrit_util.py
  78. git-cache
  79. git-cl
  80. git-crrev-parse
  81. git-drover
  82. git-find-releases
  83. git-footers
  84. git-freeze
  85. git-gs
  86. git-hyper-blame
  87. git-map
  88. git-map-branches
  89. git-mark-merge-base
  90. git-nav-downstream
  91. git-nav-upstream
  92. git-new-branch
  93. git-number
  94. git-rebase-update
  95. git-rename-branch
  96. git-reparent-branch
  97. git-retry
  98. git-runhooks
  99. git-squash-branch
  100. git-thaw
  101. git-upstream-diff
  102. git_cache.py
  103. git_cl.py
  104. git_cl_completion.sh
  105. git_common.py
  106. git_dates.py
  107. git_drover.py
  108. git_find_releases.py
  109. git_footers.py
  110. git_freezer.py
  111. git_hyper_blame.py
  112. git_map.py
  113. git_map_branches.py
  114. git_mark_merge_base.py
  115. git_nav_downstream.py
  116. git_new_branch.py
  117. git_number.py
  118. git_rebase_update.py
  119. git_rename_branch.py
  120. git_reparent_branch.py
  121. git_retry.py
  122. git_squash_branch.py
  123. git_upstream_diff.py
  124. gn
  125. gn.bat
  126. gn.py
  127. goma_auth
  128. goma_auth.bat
  129. goma_ctl
  130. goma_ctl.bat
  131. GOMA_OWNERS
  132. gsutil.py
  133. gsutil.py.bat
  134. gsutil.vpython
  135. led
  136. led.bat
  137. LICENSE
  138. luci-auth
  139. luci-auth.bat
  140. lucicfg
  141. lucicfg.bat
  142. mac_toolchain
  143. metrics.py
  144. metrics.README.md
  145. metrics_utils.py
  146. my_activity.py
  147. ninja
  148. ninja-linux32
  149. ninja-linux64
  150. ninja-mac
  151. ninja.exe
  152. ninjalog.README.md
  153. ninjalog_uploader.py
  154. ninjalog_uploader_wrapper.py
  155. OWNERS
  156. owners.py
  157. owners_finder.py
  158. post_build_ninja_summary.py
  159. PRESUBMIT.py
  160. presubmit_canned_checks.py
  161. presubmit_support.py
  162. profile.xml
  163. prpc
  164. prpc.bat
  165. pylint
  166. pylint-1.5
  167. pylint-1.6
  168. pylint-1.7
  169. pylint-1.8
  170. pylint-1.9
  171. pylint.bat
  172. pylint_main.py
  173. pylintrc
  174. python_runner.sh
  175. README.gclient.md
  176. README.git-cl.md
  177. README.md
  178. repo
  179. roll-dep
  180. roll-dep.bat
  181. roll_dep.py
  182. scm.py
  183. setup_color.py
  184. split_cl.py
  185. subcommand.py
  186. subprocess2.py
  187. update_depot_tools
  188. update_depot_tools.bat
  189. update_depot_tools_toggle.py
  190. upload_metrics.py
  191. upload_to_google_storage.py
  192. vpython
  193. vpython.bat
  194. vpython3
  195. vpython3.bat
  196. WATCHLISTS
  197. watchlists.py
  198. weekly
  199. wtf
  200. yapf
  201. yapf.bat
README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.