Google Git
Sign in
chromium / chromium / src / 856fc5567263cadd3edcfd56c1d8e6e6b6873f07
commit856fc5567263cadd3edcfd56c1d8e6e6b6873f07[log] [tgz]
authorYuki Yamada <yukiy@google.com>Thu Aug 23 11:31:06 2018
committerCommit Bot <commit-bot@chromium.org>Thu Aug 23 11:31:06 2018
tree8b4ff334a4de2c19b8f2f197162285fd847c3c0a
parentae9017a2c57f24368c95deaa7c4426ef2d1e9d97 [diff]
Check script execution is forbidden or not only in MainWorld

We should not forbid script execution in isolated worlds when
dispatching events (it should be operated by disabling Chrome
extension), so checking execution setting is necessary only in main
world.
V8EventListenerOrEventHandler::CallListenerFunction() already
implements this, so this CL make
GeneratedCodeHelper::IsCallbackRunnable() to do the same conditional
check for other callbacks generated by IDL files.

Test for this is already exists:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/events/events-in-isolated-world.html

Bug: 872138, 608286, 608641
Change-Id: Ibc38e6033d6d0462362012f1c49271548c26a8ec
Reviewed-on: https://chromium-review.googlesource.com/1186212
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Yuki Yamada <yukiy@google.com>
Cr-Commit-Position: refs/heads/master@{#585449}
1 file changed
tree: 8b4ff334a4de2c19b8f2f197162285fd847c3c0a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .