commit | 859dfccd8668aeef181d1908de102768d54fc34e | [log] [tgz] |
---|---|---|
author | Xi Cheng <chengx@chromium.org> | Mon Jul 02 23:06:41 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Jul 02 23:06:41 2018 |
tree | 3be00e982ff8003589030ff72fe2dfff229b56bc | |
parent | 66761161a74bfafc800e902aba75b91e5c36db23 [diff] |
Introduce ProfileBuilder interface Now the profiler accepts an instance of a ProfileBuilder's subclass at construction. Therefore, the profiler is agnostic of the profile representation. Samples would not be stored by the profiler but instead provided to the ProfileBuilder's subclass to do with them as it chooses. This CL also changes CallStackProfileBuilder (originally named SamplingProfileBuilder) to implement this interface and moves it to call_stack_profile_builder.{h,cc}. Unit tests are added for this new class. In stack_sampling_profiler_unittest.cc, we introduce TestProfileBuilder which implements the interface. We also removed the CallStackProfile related operations from this test the StackSamplingProfiler no longer operates on CallStackProfiles. Bug: 851163 Change-Id: Ie044b65abb085012a2c25fef7744366aec5a1103 Reviewed-on: https://chromium-review.googlesource.com/1115509 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Mike Wittman <wittman@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#572033}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .