commit 85afa9864df6d1a5318d6e4f22a3855bdbdb0913
author Giovanni Ortuño Urquidi <ortuno@chromium.org> Mon Jun 18 08:08:33 2018
committer Commit Bot <commit-bot@chromium.org> Mon Jun 18 08:08:33 2018
tree 9edf034fc28856d9a6e6529a9f29f0a3da574439
parent f0b20f774b23bc231b386f3c845228fa76be1512

Revert "[Mac] Fix form control rendering on 10.14 Mojave."

This reverts commit e7652b9e1dbc2a95964864161283f4b8665154f3.

Reason for revert: SandboxV2Test.SandboxProfileTest is failing on mac

The test has been failing since this CL landed. There doesn't seem
to be any other culprit. A lot of tests have been failing on mac
for a while, so apologies in advance if this revert is incorrect.

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/33158

[ RUN      ] SandboxV2Test.SandboxProfileTest
[29390:779:0615/235812.468905:11042865975282:WARNING:test_suite.cc(240)] Test launcher output path /var/folders/9x/6c6sv3cj4j53wzpzthbp4ksm0000gm/T/.org.chromium.Chromium.u2ydbY/test_results.xml exists. Not adding test launcher result printer.
[29390:779:0615/235812.562300:11042959366455:FATAL:sandbox_mac_v2_unittest.mm(113)] Check failed: result. line 123: unbound variable: prefix
0   content_unittests                   0x000000010a96c29c base::debug::StackTrace::StackTrace(unsigned long) + 28
1   content_unittests                   0x000000010a8f3171 logging::LogMessage::~LogMessage() + 225
2   content_unittests                   0x0000000108751c4b content::SandboxProfileProcess() + 3499
3   content_unittests                   0x000000010a128248 base::TestSuite::Run() + 104
4   content_unittests                   0x000000010a13ba1c base::(anonymous namespace)::LaunchUnitTestsInternal(base::OnceCallback<int ()>, unsigned long, int, bool, base::OnceCallback<void ()>) + 284
5   content_unittests                   0x000000010a13b8d0 base::LaunchUnitTests(int, char**, base::OnceCallback<int ()>) + 160
6   content_unittests                   0x000000010874fbf6 main + 198
7   libdyld.dylib                       0x00007fff993895c9 start + 1
../../content/renderer/sandbox_mac_v2_unittest.mm:182: Failure
Expected equality of these values:
  exit_code
    Which is: 1
  0
Stack trace:
0   content_unittests                   0x000000010e5750cb testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop(int) + 91
1   content_unittests                   0x000000010e574a89 testing::internal::AssertHelper::operator=(testing::Message const&) const + 89
2   content_unittests                   0x000000010df21a94 content::SandboxV2Test_SandboxProfileTest_Test::TestBody() + 804
[  FAILED  ] SandboxV2Test.SandboxProfileTest (273 ms)


Original change's description:
> [Mac] Fix form control rendering on 10.14 Mojave.
> 
> The renderers need to talk to the CVMS server (OpenCL compiler), which
> then outputs codesigned blobs that can be loaded in to the process. This
> is required for drawing the form controls.
> 
> In addition, another Metal bundle location (in /Library) is permitted.
> 
> Bug: 850021, 847518
> Change-Id: I67106972baf5fc55fccd8f7deff3f47cbea076b5
> Reviewed-on: https://chromium-review.googlesource.com/1103127
> Reviewed-by: Greg Kerr <kerrnel@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567877}

TBR=kerrnel@chromium.org,rsesek@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 850021, 847518
Change-Id: Ife268e2d49abc98ad3708545223667e0fb12190c
Reviewed-on: https://chromium-review.googlesource.com/1104037
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567946}