commit | 87e865b9707c201bcc335485698d79c9b368c1e6 | [log] [tgz] |
---|---|---|
author | Quang Minh Tuan Nguyen <nqmtuan@google.com> | Tue Apr 13 21:34:07 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Apr 13 21:34:07 2021 |
tree | a7a1bd0dae635012b9e8b58ec59dcca2d7b19d7a | |
parent | c84d6d0068f5bf2c866326a248d0c3089ceda0a1 [diff] |
[Findit] Add Bot-Commit +1 to Findit's revert CL As discussed in the bug, we should use Bot-Commit+1 label for Findit's revert CL. I couldn't find a way to test this. Perhaps we can only test in prod. Bug: 1187426 Change-Id: Ibff40881ec2720f00e8fd5f3b71d7d1500f49594 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2823188 Reviewed-by: Chan Li <chanli@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Quang Minh Tuan Nguyen <nqmtuan@google.com> Cr-Commit-Position: refs/heads/master@{#40133}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.