commit | 8962309fc6f8fb4f4029273491677416b3a33c58 | [log] [tgz] |
---|---|---|
author | Daniel Bratell <bratell@opera.com> | Wed Feb 20 00:06:24 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Feb 20 00:06:24 2019 |
tree | a700df6a81305fc5f53ac1dbd9e9275feafde1fb | |
parent | 8e6736f5680328757ac6844013becd01d78389f4 [diff] |
Crostini: Include header file instead of cc file Instead of a header file, crostini included chrome/browser/platform/platform_util_chromeos.cc which kind of worked but in some builds triggered link failures later because of duplicate symbols. This probably works sometimes because nobody else uses the symbols in platform_util_chromeos.o so that it is discarded before the linker notices the duplication. Not always though. Bug: 912638 Change-Id: I9b96a41e20ab5362fe800b502d788c844ac4d7f2 Reviewed-on: https://chromium-review.googlesource.com/c/1477025 Auto-Submit: Daniel Bratell <bratell@opera.com> Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#633471}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .