commit | 89ae4532e2e5a3d32a205c15b2e17e74da6617ad | [log] [tgz] |
---|---|---|
author | danakj <danakj@chromium.org> | Wed Dec 12 22:52:55 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Dec 12 22:52:55 2018 |
tree | ce11be4d9cca7544e1fe22144b52364ee2c85687 | |
parent | de910441219180faa182bd869b5a03358f57eb94 [diff] |
Clean up RenderWidget type logic for main- vs sub-frames. Remove RenderWidget::WidgetType, replace it with for_frame(), which can derive an answer from the presence of owner_delegate_ (for a main frame) and for_child_local_root_frame_ (for sub frames). This changes pepper plugin widgets from being considered frames to not, which seems okay. One piece of code wanted to run only for popup widgets but its in SetWindowRect which is not used on the pepper widget. Remove use of IsWebView() and IsWebFrameWidget() on the WebWidget from RenderWidget. Instead use for_frame() or its derivative parts. We want to stop checking for the presence of a WebFrameWidget and drop IPCs early when a RenderWidget is frozen, but there's one bug that prevents that still as the Frame (and FrameWidget) can be detached without freezing the RenderWidget (crbug.com/906340#c7). R=ajwong@chromium.org, avi@chromium.org Change-Id: I83589e2b0cf5a4c68dde77eaae87404ba1de4cc0 Bug: 912193 Reviewed-on: https://chromium-review.googlesource.com/c/1373887 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by: Albert J. Wong <ajwong@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#616093}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .