commit | 89fea2015ea4cd0e1e9f474aa3f7a03f8b903c93 | [log] [tgz] |
---|---|---|
author | Roman Sorokin <rsorokin@chromium.org> | Thu Jan 10 12:34:18 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jan 10 12:34:18 2019 |
tree | a810b26e3fd375a01e176b13b734a5a7d368a38a | |
parent | b0f72e51e673273e3e7e7111f47c836a5e577d83 [diff] |
Revert "[BlinkGenPropertyTrees] Fix ElementIsAnimatingChanged logic" This reverts commit b0eab4a3e36612417196e6766d7a770f675169c4. Reason for revert: Investigating flakiness https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYjBlYWI0YTNlMzY2MTI0MTcxOTZlNjc2NmQ3YTc3MGY2NzUxNjljNAw Original change's description: > [BlinkGenPropertyTrees] Fix ElementIsAnimatingChanged logic > > As of https://crrev.com/2a64f7b5, there is no longer a single ElementId > for an entire 'animating target' in cc. However ElementIsAnimatingChanged > still assumes that it can lookup the different types of nodes > (TransformNode, EffectNode) using a single ElementId. This caused both > incorrect logic (code that should have been executed was not as the node > could not be found) as well as DCHECK failures (again from the incorrect > branch). > > This fix is essentially a hack, and it is important to note that we don't > have a clear idea of what ElementIsAnimatingChanged is required for (i.e. > what the consequences of it not working -outside of DCHECKs - are). The > goal of this CL is just to restore the function to how it was working > before https://crrev.com/2a64f7b5. > > Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel > > Change-Id: I0d0eb0c9add83ff3c1b6d6f30858804aed300aac > Bug: 912574 > Reviewed-on: https://chromium-review.googlesource.com/c/1372173 > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621198} TBR=flackr@chromium.org,majidvp@chromium.org,smcgruer@chromium.org Change-Id: I5448fe9ff246b984916b07fbf2adfdf90ca0d896 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912574 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/c/1404158 Reviewed-by: Roman Sorokin <rsorokin@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#621553}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .