Our old TestExpectations file had problems. I like to know the effect CRs have on our test coverage. The problems prevented this:
1) 125 passing tests were marked as failing.
With 125 stealth passing tests, I would not know what different my CR would make.
2) [Crash/Failing] tests were all marked as [Skip]
Because [Skip] tests are ignored by bots, any changes in status to skipped tests
had to be manually checked by developer.
This patch correctly marks all virtual/layout_ng tests:
- all passing tests are no longer skipped.
- all failing tests are explicitly marked as such:
[ Failure ] means test has failed
[ Crashed ] means that bad thing
[ Skip ] means test has missing expectations, and cannot be run
I've cleared with dpranke and quearsley that we can mark our tests as such.
I've also created an html page that can be run inside test-layout-results that generates these TestExpectations automatically. We will all be able to use it to automate updating of TestExpectations. This will come in a separate patch.
BUG=635619
Review-Url: https://codereview.chromium.org/2905933002
Cr-Commit-Position: refs/heads/master@{#475164}
1 file changed
