| commit | 8b04654b0e251eef0b553b2c676904375b5195e9 | [log] [tgz] |
|---|---|---|
| author | Garrett Beaty <gbeaty@chromium.org> | Fri Aug 07 22:39:08 2020 |
| committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Aug 07 22:39:08 2020 |
| tree | daf58da5558ea97f2c947b3a97afea614483bf51 | |
| parent | ef6a47c9d777268bf0fcfabc10446ebff3056907 [diff] |
Revert "Remove the --factory-properties flags from scripts." This reverts commit fbbf8d266f92f8aa241dd65dcd3a92801544b147. Reason for revert: Broke archive builders Original change's description: > Remove the --factory-properties flags from scripts. > > Factories were an aspect of buildbot and aren't present in LUCI. > Multiple scripts would accept both --build-properties and > --factory-properties, but the callers would pass the same value for > both, so the --factory-properties flag was removed. archive_build.py and > asan_archive_build.py only accepted --factory-properties, but have been > changed to instead take --build-properties. > > Bug: 1008256 > Change-Id: I13bb8d8e9fe81509e643d787f127bae042c16c95 > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Recipe-Nontrivial-Roll: chrome_release > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2341767 > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> TBR=martiniss@chromium.org,gbeaty@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I44809c10bc18ce923d0645f992676bae24065c8b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1008256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/build/+/2343735 Reviewed-by: Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
If you're here to make a change to ‘recipes’ (the code located in scripts/slave/recipes*), please take a look at the README for more information pertaining to recipes.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style. Functions use lowercase_with_underscores, with the exception of the special functions RunSteps and RunTests in recipes. Use yapf (git cl format) to autoformat new code.