commit | 8b0b8ed705c0aaca894295ce12ccfc1fb2417d53 | [log] [tgz] |
---|---|---|
author | Xixuan Wu <xixuan@google.com> | Tue Mar 23 23:16:08 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Mar 23 23:16:08 2021 |
tree | fe110206b60c3bc4b2525386b30b538d27badd00 | |
parent | 6431452c8f0d894d898b21ccb1d52074ddba54d0 [diff] |
UFS: fix one case in updating deployment record when updating serial number It's possible that when the host is added to UFS, the corresponding machine doesn't have any serial number. Later users add the serial numbers back for the machine, then the deployment record should be updated also. BUG=b/179941001 TEST=make test; make dev Change-Id: I6eb6a09e55ccf4a6f4d313fb512d17e0e0f494cf Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2773453 Commit-Queue: Xixuan Wu <xixuan@chromium.org> Reviewed-by: Eshwar Narayan <eshwarn@chromium.org> Cr-Commit-Position: refs/heads/master@{#39658}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.