commit | 8c50b3ed049c736406943ac24dc40fc8ac1e782c | [log] [tgz] |
---|---|---|
author | Bruce Dawson <brucedawson@chromium.org> | Thu Feb 15 00:08:36 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Feb 15 00:08:36 2018 |
tree | d2e172397f2071b6d95b54fe1d952846ded5af2e | |
parent | b66e111357bece445f2917a82d0c29a85c288d06 [diff] |
Print Windows crash codes in hex Failure codes such as STATUS_ACCESS_VIOLATION are easily recognizable and easily differentiated when printed in hex (0xC0000005) but are cryptic and conflated when printed as decimal (-1073741819). This change teaches two of our wrapper scripts to print large negative numbers as hex so that those skilled in the Windows arts can automatically say "access violation" or "not access violation." I also removed an inelegant trailing period, for consistency. In testing with artificially inserted error codes the output is: Protoc has returned non-zero status: -99 Protoc has returned non-zero status: 0xC0000005 genperf.exe failed with exit code -99 re2c.exe failed with exit code 0xC0000005 Bug: 803617,644525 Change-Id: I627754976ff04e334010d36e5734d73421523e47 Reviewed-on: https://chromium-review.googlesource.com/917101 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#536899}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .