commit | 8cae04ed002baf0ff6cf20a7c76995792f9f4a51 | [log] [tgz] |
---|---|---|
author | Bence Béky <bnc@chromium.org> | Mon Jan 15 18:37:06 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Jan 15 18:37:06 2018 |
tree | 36cf5f5f8a0a59160112d903d47f558f13b2bd43 | |
parent | 12114f338ab44a3f780072f9a74269e20266dee9 [diff] |
Use the same HttpStreamFactoryImpl for Websockets. Currently, HttpNetworkSession owns two HttpStreamFactoryImpl instances: one for Websocket requests, one for other requests. This is unnecessary. This CL makes HttpNetworkSession own and use a single HttpStreamFactoryImpl for all requests. HttpStreamFactoryImpl manages JobControllers, and JobController manages Jobs. Every JobController and Job corresponds to a request and is thus either Websocket or non-Websocket. Before this CL, Job called JobController through the Job::Delegate interface to find out whether it was for a Websocket request, and JobController called HttpStreamFactoryImpl. This CL removes these calls and instead passes a Boolean in the constructors that is stored in const members of JobController and Job. Bug: 801564 Change-Id: I9e5784713f38dd5871455c96626e9e0d3354e160 Reviewed-on: https://chromium-review.googlesource.com/864562 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#529314}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .