Google Git
Sign in
chromium / chromium / src / 8d1c605a78d21df1b0c87dc7a7d14b319b3730c4
commit8d1c605a78d21df1b0c87dc7a7d14b319b3730c4[log] [tgz]
authorBence Béky <bnc@chromium.org>Wed Feb 07 12:48:15 2018
committerCommit Bot <commit-bot@chromium.org>Wed Feb 07 12:48:15 2018
treeb5448d2182c81228f56d7085b0bc4ebd30fd19d6
parent5a64040dc63c39874d952905d188ba398464d62d [diff]
Remove fake WebSocket test classes.

Create DummyConnectDelegate and DummyWebSocketStreamRequest.  Rename
DeterministicKeyWebSocketHandshakeStreamCreateHelper to
TestWebSocketHandshakeStreamCreateHelper, and add a constructor to use
these dummy classes.

Remove FakeWebSocketHandshakeStreamBase and its derived classes
FakeWebSocketHandshakeStream and AsyncFakeWebSocketHandshakeStream.
Also remove FakeWebSocketStreamCreateHelper that hands out
FakeWebSocketHandshakeStream instances.  Convert five tests to use
TestWebSocketHandshakeStreamCreateHelper, which is based on the real
WebSocketHandshakeStreamCreateHelper, and add/modify mock data
accordingly.

This change is not directly related to but done in preparation for
implementing WebSockets over HTTP/2.

Bug: 801564
Change-Id: I7a9fee80f0ce6b4dccf59f62570e52b5a64131f8
Reviewed-on: https://chromium-review.googlesource.com/904823
Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534986}
7 files changed
tree: b5448d2182c81228f56d7085b0bc4ebd30fd19d6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .