commit | 8fd04b5fbba25e412874ff15c659c25fb9dcc12c | [log] [tgz] |
---|---|---|
author | Tessa Nijssen <tnijssen@google.com> | Thu Aug 16 21:12:00 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Aug 16 21:12:00 2018 |
tree | 6e414ce2f5d54cacb857433c9677c8460f054f1e | |
parent | cdbb74a67dfa2faaf61701b6ca2bb1b1aa26c2f9 [diff] |
[Mac] Moved TextSuggestionsTouchBarController's Range Validity Check Previously, -updateTextSelection:range:offset: could receive an invalid range from WebContentsTextObserver::DidChangeTextSelection(). This invalid range would then cause a crash in -requestSuggestions. A check has been added to -updateTextSelection:range:offset: to make sure that a selection with an invalid range is not passed to -requestSuggestions. This should prevent future crashes. TextSuggestionsTouchBarControllerTest.InvalidRange tests that an invalid range does not crash the controller and is handled properly. Bug: 717553 Change-Id: I69f49cb1f1819e1d528837767dfb894d8652e84d Reviewed-on: https://chromium-review.googlesource.com/1178467 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Sarah Chan <spqchan@chromium.org> Commit-Queue: Tessa Nijssen <tnijssen@google.com> Cr-Commit-Position: refs/heads/master@{#583815}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .