commit | 90022e36fddcafdb31ac5bd090215bbea22472c2 | [log] [tgz] |
---|---|---|
author | Miguel Casas <mcasas@chromium.org> | Wed Jan 09 15:06:51 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Jan 09 15:06:51 2019 |
tree | 40ab81c6da3efb7197cc3e70bd9a89b1f5abd7f9 | |
parent | a69182a86bd5a5e1ff3b7ecd0bf17c943a1b75ff [diff] |
RELAND2: MediaRecorder: only announce h264/avc1 support if RTC_USE_H264 The relanded CL got reverted as well (!) because it still broke media_capabilities/encodingInfo.html; this CL splits the avc1/h264 parts in a file on its own, and rewrites all of those tests to not use generate_tests (see comment in crrev.com/c/1393538). Only the -avc1.html tests are marked as [Pass Failure] in TestExpectations. Original 2nd CL description -------------------------------------------- The original CL got reverted because: - It broke media_capabilities/encodingInfo.html - It broke the MediaRecorder LayoutTests on non-Android bots when RTC_USE_H264 is not defined (which is pretty pervasive, it turns out). This CL then adds the necessary TestExceptions. Original CL description ------------------------------------------------ Support for AVC1 encoding (a.k.a. H264) is dependent on RTC_USE_H264 [1], but due to an omission, this was not tested when enumerating the video codecs. This CL fixes that. [1] https://cs.chromium.org/chromium/src/third_party/webrtc/webrtc.gni?type=cs&q=rtc_use_h264&sq=package:chromium&g=0&l=156 Bug: 809980, 719023 Change-Id: I865e9007ffce810998f62d1e187bf4ecf499badd Reviewed-on: https://chromium-review.googlesource.com/c/1395887 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#620078} Reviewed-on: https://chromium-review.googlesource.com/c/1396452 Cr-Original-Commit-Position: refs/heads/master@{#620453} Reviewed-on: https://chromium-review.googlesource.com/c/1399823 Reviewed-by: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#621142}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .