commit | 9018eb2193ac04ad0b89294d90fa7a14c4d5f884 | [log] [tgz] |
---|---|---|
author | Jack Neus <jackneus@google.com> | Mon Mar 22 21:18:28 2021 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Mar 22 21:18:28 2021 |
tree | bed620ecb8d56d9c07526083d8a512532810b6d9 | |
parent | 028d48f1c43f7585891eb1361e4fe335943a48a3 [diff] |
phosphorus/prejob: clear existing fields before setting cros-version for TLS A DUT may have a stale job_repo_url value that can cause downstream failures when it is referenced against the cros-version label. This change clears job_repo_url (and any existing cros-version label) before applying the new cros-version label. BUG=b:182579728 TEST=go test Change-Id: Iba444ebc0e94b5b4ba3540b69f0842915030f879 Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2780216 Reviewed-by: Jared Loucks <jaredloucks@google.com> Commit-Queue: Jack Neus <jackneus@google.com> Cr-Commit-Position: refs/heads/master@{#39603}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.