Google Git
Sign in
chromium / infra / infra / 910054c8f1819dcbe93de5a374ad5ebc98d68430
commit910054c8f1819dcbe93de5a374ad5ebc98d68430[log] [tgz]
authorHaiyang Pan <hypan@google.com>Thu Jan 07 17:22:39 2021
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jan 07 17:22:39 2021
tree1bc79e6a1f86cfe117b0c0d044fbc3fafe293eef
parentaf414e6a26a8e94d3f2c9833455c2facb347a960 [diff]
Update "tool" and "dep" of 3pp packages to the new format.

This CL should be landed together with crrev.com/c/2528117.

With the crrev.com/c/2528117, the "tool" and "dep" in PB need to be
changed to the format <pkg_prefix>/<pkg_name>, rather than the original
<pkg_name>.

Other changes are:
* In tools/re2c/3pp.pb, the URL now points to "download" rather than
  "archive", otherwise the install.sh won't work correctly.
  (static_libs/nsl/3pp.pb has a similar issue, but it doesn't have
  "download" link for the current version 1.0.3).
* Copied "cpython_common/ssl_suffix.py" to "cpython" and "cpython3".
  Due to the change in "copy package definition" in support_3pp/source.py
  in crrev.com/c/2528117, cpython_common cannot be accessed by cpython
  and cpython3 when running install.sh.
* Fixed "run_remotely.sh" script to work with latest LED, and runs on
  bots with dimension "role=docker" which have "docker" binary.

Bug: 1152854, 1082598
Change-Id: Ifd96eecf5da820ebb52a24c508f9561d5025c32e
Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2570530
Commit-Queue: Haiyang Pan <hypan@google.com>
Reviewed-by: Brian Ryner <bryner@google.com>
Cr-Commit-Position: refs/heads/master@{#37375}
24 files changed
tree: 1bc79e6a1f86cfe117b0c0d044fbc3fafe293eef
  1. 3pp/
  2. appengine/
  3. appengine_module/
  4. bootstrap/
  5. build/
  6. chromeperf/
  7. cipd/
  8. crdx/
  9. doc/
  10. docker/
  11. glyco/
  12. go/
  13. infra/
  14. node/
  15. packages/
  16. python_pb2/
  17. recipes/
  18. test/
  19. utils/
  20. .gitattributes
  21. .gitignore
  22. .style.yapf
  23. .yapfignore
  24. codereview.settings
  25. CONTRIBUTING.md
  26. DEPS
  27. LICENSE
  28. navbar.md
  29. OWNERS
  30. PRESUBMIT.py
  31. README.md
  32. run.py
  33. test.py
  34. WATCHLISTS
  35. WHITESPACE
README.md

infra.git repository

Testing Welcome to the Chrome Infra repository!

Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.

Entry points

  • run.py: wrapper script to run programs contained in subdirectories without having to deal with sys.path modifications.
  • test.py: multi-purpose script to run tests.
  • packages/infra_libs/: generally useful functions and classes
  • infra/services/: standalone programs intended to be run as daemons.
  • infra/tools: command-line tools, intended to be run by developers.
  • appengine/: many Chrome-infra-managed AppEngine applications
  • infra/experimental: for, well, experimental stuff. Once they are stabilized and reviewed, they should be moved in a more permanent place.

Miscellaneous technical stuff

  • bootstrap/: utilities to set up a proper Python virtual environment.
  • infra/path_hacks: submodules of this modules give access to modules in the build/ repository. from infra.path_hacks.common import <stg> is actually getting <stg> from build/scripts/common.
  • utils/: purpose? utils?
  • Need to bump infra/deployed to pick up changes?
    • git push origin <updated hash>:deployed
    • mail chrome-troopers@, include:
      • previously deployed hash (for quick rollback)
      • the hash you just pushed
      • the list of CLs that made this push necessary
      • the output of the git push command

Integrating tests with test.py

If you've added a new module, run your tests with test.py:

  1. Create a .coveragerc file in the root directory of the module you want to test. Take a look at another .coveragerc to see what to include in that.
  2. Create a “test” directory in the root directory of the module you want to test. Move your *_test.py files to this directory.

Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>.

Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py files in each directory of your module so Python recognizes it as a package.

Style

The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores. Use yapf (git cl format) to autoformat new code.