commit | 91a32c5e39d2c1e789e7fe63355bc2ec399f68db | [log] [tgz] |
---|---|---|
author | Jordan Bayles <jophba@chromium.org> | Fri Feb 22 21:28:17 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Feb 22 21:28:17 2019 |
tree | 8ad163d8e68a16038afc1caa3f128f0ed422669d | |
parent | ac0cb2c1148d749a7e0c9f7e098788bc3077e8a8 [diff] |
CppLint changes for VSCode cpplint plugin This patch makes some changes to the cpplint.py script for integration with the VSCode cpplint plugin, available here: https://marketplace.visualstudio.com/items?itemName=mine.cpplint Specifically, the "--repository" and "--headers" options currently cause our version of cpplint to crash, when we should at worst ignore them. A minor messaging tweak outputting the contents of the GetoptError, to make debugging input argument bugs easier, is included Change-Id: Id78616f5e2fdecb7da650042f0658623477ef9cb Reviewed-on: https://chromium-review.googlesource.com/c/1481938 Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Jordan Bayles <jophba@chromium.org>
Tools for working with Chromium development. It requires python 2.7.
The most important tools are:
fetch
: A gclient
wrapper to checkout a project. Use fetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Use git cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.There are a lot of git utilities included.
depot_tools
updates itself automatically when running gclient
tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows, or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
To contribute change for review:
git new-branch <somename> # Hack git add . git commit -a -m "Fixes goat teleporting" # find reviewers git cl owners git log -- <yourfiles> # Request a review. git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail # Edit change description if needed. git cl desc # If change is approved, flag it to be committed. git cl set-commit # If change needs more work. git rebase-update ... git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
Until 2018, our cpplint.py
was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py
in depot_tools
, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.