| commit | 931533d38f6b44a56f7a768e91d71f2f167c7897 | [log] [tgz] |
|---|---|---|
| author | krasin <krasin@google.com> | Sat Dec 05 00:24:33 2015 |
| committer | Commit bot <commit-bot@chromium.org> | Sat Dec 05 00:26:00 2015 |
| tree | f6b7fb206e8011003c01518649b5fd0a85fa9595 | |
| parent | cfeeea2c8e840dd67af7463088bf02bf200097d0 [diff] |
Revert of Enable Control Flow Integrity for the official Linux Chrome. (patchset #1 id:1 of https://codereview.chromium.org/1501593003/ ) Reason for revert: Buildbot timed out: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/6284 "command timed out: 3600 seconds without output, attempting to kill" It's hard to say why does the buildbot so much slower than a local build. Possibly, not enough RAM. Original issue's description: > Enable Control Flow Integrity for the official Linux Chrome. > > This CL turns on CFI, a security check: > https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity > http://clang.llvm.org/docs/ControlFlowIntegrity.html > > This feature enables LTO (Link-Time Optimization) builds, which slow down the linker by 3x-4x. > CFI also comes with a code size overhead of about 7%-9%. The runtime CPU cost is less than 1%, > and should not be an issue. > > BUG=chromium:464797 > Intent to Implement thread: > https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pbJqt6ccMII/7iJC2oklCAAJ > > This is a second attempt to land the CL. The first one: > https://codereview.chromium.org/1393283005/ > > Committed: https://crrev.com/abbfcc7930834381e05c31068ac2256cb9ea4f49 > Cr-Commit-Position: refs/heads/master@{#363267} TBR=thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:464797 Review URL: https://codereview.chromium.org/1501873002 Cr-Commit-Position: refs/heads/master@{#363313}