Google Git
Sign in
chromium / chromium / src / 9457a567cb17e9d93675f3f42b5d25bea22d0d59
commit9457a567cb17e9d93675f3f42b5d25bea22d0d59[log] [tgz]
authorMarc Treib <treib@chromium.org>Fri Nov 30 13:14:57 2018
committerCommit Bot <commit-bot@chromium.org>Fri Nov 30 13:14:57 2018
tree69ed15248ec02b1a02559905e99087592e23ef63
parent4e76a579eae62db2bbb6ed808b1665076aa25815 [diff]
Simplify ProfileSyncService::IsSyncConfirmationNeeded

This removes checks for !IsLocalSyncEnabled() and IsSignedIn(), which
are implied by IsAuthenticatedAccountPrimary().
With this, IsSyncConfirmationNeeded is implemented fully in terms of
the public SyncService interface, which means we'll be able to move it
out of ProfileSyncService in a followup.

Bug: 884159
Change-Id: I532065b4517e2156c32b8eb91bf613ba23c4a267
Reviewed-on: https://chromium-review.googlesource.com/c/1356543
Reviewed-by: Florian Uunk <feuunk@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612626}
1 file changed
tree: 69ed15248ec02b1a02559905e99087592e23ef63
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .