| commit | 94af7186bb57ba9e1a2dea4c2bd41ac5e418a18e | [log] [tgz] |
|---|---|---|
| author | sigbjornf <sigbjornf@opera.com> | Mon Nov 30 09:42:57 2015 |
| committer | Commit bot <commit-bot@chromium.org> | Mon Nov 30 09:43:49 2015 |
| tree | f6b62879230a9dd1794b5c2a98c1da4571164622 | |
| parent | 191ee45e392a8ad766bd397b9f35c9f2778bffa1 [diff] |
Revert of "[sql] Remove part of WebDatabase SQLite patch." (patchset #1 of https://codereview.chromium.org/1473963002 ) Reason for revert: Unfortunately, this seems to have introduced flaky shutdown crashes on storage/websql/open-database-creation-callback.html across bots, http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=storage%2Fwebsql%2Fopen-database-creation-callback.html http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/5769 Original issue's description: > [sql] Remove part of WebDatabase SQLite patch. > > findReusableFd() calls stat() on the filename to determine the inode > and device to figure out if a previously-closed file descriptor can be > reused. Since WebDatabase file names are resolved by the browser, > this stat() can never succeed in the renderer, thus there is no point > to calling the function. > > This SQLite code path is an optimization to reduce close/open churn, > it is not necessary for correct operation. > > BUG=none > > Review URL: https://codereview.chromium.org/1473963002 > Cr-Commit-Position: refs/heads/master@{#361825} TBR=shess@chromium.org,michaeln@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1485603003 Cr-Commit-Position: refs/heads/master@{#362112}