Google Git
Sign in
chromium / chromium / src / 94c9a948334f6d5d910932ba74ce1316c199de04
commit94c9a948334f6d5d910932ba74ce1316c199de04[log] [tgz]
authorJesse Selover <jselover@chromium.org>Wed Jan 16 01:18:04 2019
committerCommit Bot <commit-bot@chromium.org>Wed Jan 16 01:18:04 2019
treefcf02364b17a08f916d8e05bb8efeadc4d8a8fd7
parenta92ab3a5b0939fc02b13e6bcce9e5c0b4080e205 [diff]
Use the BoringSSL callback for certificate verification.

This moves certificate verification to within the handshake, instead of
a separate step afterwards, which allows us to verify the certificate
before prompting for client certificates.

It also means that certificate errors result in incomplete handshakes,
so this also changes SSLClientSocket unit tests not to expect connected
sockets after certificate errors.

Bug: 347402
Change-Id: I0a93da1dee5be697fa7d5c74aae206d370f97d5b
Reviewed-on: https://chromium-review.googlesource.com/c/1259123
Commit-Queue: Jesse Selover <jselover@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622963}
7 files changed
tree: fcf02364b17a08f916d8e05bb8efeadc4d8a8fd7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .