Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 954943005: Remove SK_LEGACY_STROKE_CURVES (Closed)

Created:
5 years, 9 months ago by f(malita)
Modified:
5 years, 7 months ago
Reviewers:
caryclark, reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SK_LEGACY_STROKE_CURVES BUG=490269 TBR=caryclark@google.com,reed@google.com Committed: https://crrev.com/2a3211d56b0395c3881d8303b43d39a59391fe9d Cr-Commit-Position: refs/heads/master@{#331038}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Patch Set 4 : expectations #

Patch Set 5 : updated expectations #

Patch Set 6 : rebased #

Patch Set 7 : one more SP suppression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+976 lines, -4 lines) Patch
M skia/config/SkUserConfig.h View 1 2 3 4 5 6 1 chunk +0 lines, -4 lines 0 comments Download
M skia/skia_test_expectations.txt View 1 2 3 4 5 6 1 chunk +976 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
f(malita)
5 years, 9 months ago (2015-02-25 17:17:41 UTC) #1
f(malita)
I tried to roll this with the SK_SUPPORT_LEGACY_ADDOVAL change, but gave up because I noticed ...
5 years, 9 months ago (2015-03-09 14:35:41 UTC) #2
f(malita)
After Cary's last fix for https://code.google.com/p/skia/issues/detail?id=3843, I think this is good to go. Added suppressions, ...
5 years, 7 months ago (2015-05-20 18:41:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954943005/120001
5 years, 7 months ago (2015-05-22 00:49:58 UTC) #6
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 7 months ago (2015-05-22 00:55:06 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 00:56:03 UTC) #8
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/2a3211d56b0395c3881d8303b43d39a59391fe9d
Cr-Commit-Position: refs/heads/master@{#331038}

Powered by Google App Engine
This is Rietveld 408576698