Google Git
Sign in
chromium / chromium / src / 95f31b9f36c02b47c6872520041fedb491ce8693
commit95f31b9f36c02b47c6872520041fedb491ce8693[log] [tgz]
authorMin Qin <qinmin@chromium.org>Tue Jun 12 17:13:49 2018
committerMin Qin <qinmin@chromium.org>Tue Jun 12 17:13:49 2018
tree8006f1e9d32c02716f4c06a7220a52e3c489ba0f
parent27813b0c26e46ed1906d9cab2d379c3b9c245961 [diff]
Prompt user before openning a download from extension

Downloads api allows an extension to open a download with a user gesture.
However, the current user gesture check is passed from the renderer,
and it can be easily compromised.
This CL adds a prompt dialog to notify user before opening a download.

BUG=666824

Change-Id: I6ec9709fa183f9784db323603f356dc6aa9ea6e1
Reviewed-on: https://chromium-review.googlesource.com/1069320
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#564250}(cherry picked from commit 7b7cbbbf249aaa55b915ed3b316aceeb5c0c0bdb)
Reviewed-on: https://chromium-review.googlesource.com/1097535
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#302}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
10 files changed
tree: 8006f1e9d32c02716f4c06a7220a52e3c489ba0f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. webrunner/
  53. .clang-format
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. AUTHORS
  61. BUILD.gn
  62. CODE_OF_CONDUCT.md
  63. codereview.settings
  64. DEPS
  65. ENG_REVIEW_OWNERS
  66. LICENSE
  67. LICENSE.chromium_os
  68. OWNERS
  69. PRESUBMIT.py
  70. PRESUBMIT_test.py
  71. PRESUBMIT_test_mocks.py
  72. README.md
  73. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .