commit | 9730f8860286034621b720013c8f55b47dbe5553 | [log] [tgz] |
---|---|---|
author | Justin Suen <justinsuen@google.com> | Tue Nov 24 22:03:10 2020 |
committer | LUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Nov 24 22:03:10 2020 |
tree | bf97aed02c5641569315ba5708ccdb1b3bd6d04e | |
parent | d4a3764e50406f3e479c3e8473d5a04d105aa50b [diff] |
Manual Repair: remove faulty state change for repair history State change keeps triggering if the DUT has never been repaired before. Currently, when the state is empty, the UI will attempt to dispatch fetch action to update the repair history continuously. This happens when a DUT has never had a repair record before. The continuous calls sometimes affect other RPC actions dispatched by the UI. Added conditions and moved state parsing out of dispatch promise. BUG=chromium:1134710 TEST=make mr-dev Change-Id: I1a3658f2a1aadbf9be2ef5ce49c8950ba52a21bf Reviewed-on: https://chromium-review.googlesource.com/c/infra/infra/+/2559014 Commit-Queue: Justin Suen <justinsuen@google.com> Reviewed-by: Xixuan Wu <xixuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#36683}
Testing Welcome to the Chrome Infra repository!
Wondering where to start? Check out General Chrome Infrastructure documentation. In particular, to check out this repo and the rest of the infrastructure code, follow the instructions here. The rest of this page is specific to this repo.
sys.path
modifications.from infra.path_hacks.common import <stg>
is actually getting <stg>
from build/scripts/common.git push origin <updated hash>:deployed
git push
commandIf you've added a new module, run your tests with test.py:
*_test.py
files to this directory.Double-check that your tests are getting picked up when you want them to be: ./test.py test <path-to-package>
.
Tests still not getting picked up by test.py? Double-check to make sure you have __init__.py
files in each directory of your module so Python recognizes it as a package.
The preferred style is PEP8 with two-space indent; that is, the Chromium Python style, except functions use lowercase_with_underscores
. Use yapf (git cl format
) to autoformat new code.